Switch to external stringset implementation.

Switch to external stringset implementation.

R=dnj@chromium.org, estaab@chromium.org, maruel@chromium.org, tandrii@chromium.org, vadimsh@chromium.org
BUG=

Committed: https://github.com/luci/gae/commit/af083991f76aac1bb1c5dcb160676ef17c496b68

[dnj, 2015-08-31 23:27:26]

https://codereview.chromium.org/1312433013/diff/1/impl/memory/datastore_index...
File impl/memory/datastore_index_selection.go (right):

https://codereview.chromium.org/1312433013/diff/1/impl/memory/datastore_index...
impl/memory/datastore_index_selection.go:238: props :=
stringset.New(len(q.eqFilters) + (len(q.suffixFormat) - len(q.suffixFormat)))
A + (B - B)?

https://codereview.chromium.org/1312433013/diff/1/impl/memory/datastore_query.go
File impl/memory/datastore_query.go (right):

https://codereview.chromium.org/1312433013/diff/1/impl/memory/datastore_query...
impl/memory/datastore_query.go:586: dupCheck := stringset.New(len(fieldName) +
len(q.project))
Why len(q.project)? Doesn't seem to influence the number of elements added to
the Set.

[Vadim Sh., 2015-09-10 21:17:36]

is it ok that luci\luci-go and luci\gae repos now mutually depend on each other?

[dnj (Google), 2015-09-10 21:21:00]

On 2015/09/10 21:17:36, Vadim Sh. wrote:
> is it ok that luci\luci-go and luci\gae repos now mutually depend on each
other?

They have for a while now (e.g., .../luci-go/common/errors").

[M-A Ruel, 2015-09-10 21:26:37]

On 2015/09/10 21:17:36, Vadim Sh. wrote:
> is it ok that luci\luci-go and luci\gae repos now mutually depend on each
other?

lol

BTW why not use https://github.com/xtgo/set instead? It's so much more efficient
and smart (IMHO). Which reminds me that we need to finalize the gophercon
report. oops.

[iannucci, 2015-09-10 21:31:11]

On 2015/09/10 21:26:37, M-A Ruel wrote:
> On 2015/09/10 21:17:36, Vadim Sh. wrote:
> > is it ok that luci\luci-go and luci\gae repos now mutually depend on each
> other?
> 
> lol
> 
> BTW why not use https://github.com/xtgo/set instead? It's so much more
efficient
> and smart (IMHO). Which reminds me that we need to finalize the gophercon
> report. oops.

Hm... I searched but didn't find that. I found
https://github.com/deckarep/golang-set which looked kinda gross
implementation-wise.

The xtgo/set interface looks WAY more complicated than what I actually need...
I'm just using this for membership tests. Maybe I could implement the interface
with xtgo/set behind the scenes later?

[iannucci, 2015-09-10 21:32:20]

https://codereview.chromium.org/1312433013/diff/1/impl/memory/datastore_index...
File impl/memory/datastore_index_selection.go (right):

https://codereview.chromium.org/1312433013/diff/1/impl/memory/datastore_index...
impl/memory/datastore_index_selection.go:238: props :=
stringset.New(len(q.eqFilters) + (len(q.suffixFormat) - len(q.suffixFormat)))
On 2015/08/31 23:27:26, dnj wrote:
> A + (B - B)?

Oops. Fixed.

https://codereview.chromium.org/1312433013/diff/1/impl/memory/datastore_query.go
File impl/memory/datastore_query.go (right):

https://codereview.chromium.org/1312433013/diff/1/impl/memory/datastore_query...
impl/memory/datastore_query.go:601: for _, p := range q.project {
look further :)

[iannucci, 2015-09-10 21:34:27]

Also... if we want to unnecessarily optimize this, I think this would be much
better implemented with a trie ;D

[iannucci, 2015-09-11 00:23:47]

On 2015/09/10 21:34:27, iannucci wrote:
> Also... if we want to unnecessarily optimize this, I think this would be much
> better implemented with a trie ;D

LGTAnyone?

[iannucci, 2015-09-12 00:55:18]

Can pls to has lgtm mebbeh?

[estaab, 2015-09-12 01:11:15]

lgtm

[iannucci, 2015-09-12 01:25:19]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2015-09-12 01:25:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312433013/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312433013/40001

[commit-bot: I haz the power, 2015-09-12 01:28:35]

Committed patchset #3 (id:40001) as
https://github.com/luci/gae/commit/af083991f76aac1bb1c5dcb160676ef17c496b68