src/IceInst.cpp - Issue 1312433004: Weight variables by their number of uses for register allocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInst.cpp

Issue 1312433004: Weight variables by their number of uses for register allocation. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Count uses in VMetadata Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInst.cpp

diff --git a/src/IceInst.cpp b/src/IceInst.cpp

index 4b89eb77b0fa88f5f692f637a5ef892305b1a62b..1059a4785879bac695c57a76c394618d19c49e7e 100644

--- a/src/IceInst.cpp

+++ b/src/IceInst.cpp

@@ -203,7 +203,7 @@ bool Inst::liveness(InstNumberT InstNumber, LivenessBV &Live,

Operand *Src = getSrc(I);

SizeT NumVars = Src->getNumVars();

for (SizeT J = 0; J < NumVars; ++J, ++VarIndex) {

- const Variable *Var = Src->getVar(J);

jvoung (off chromium) 2015/08/28 20:31:45 any reason for this change?

ascull 2015/08/28 21:22:36 There was, but no longer. Done.

+ Variable *Var = Src->getVar(J);

SizeT VarNum = Liveness->getLiveIndex(Var->getIndex());

if (!Live[VarNum]) {

setLastUse(VarIndex);

« no previous file with comments | « src/IceCfgNode.cpp ('k') | src/IceLiveness.cpp » ('j') | src/IceOperand.h » ('J')