Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Side by Side Diff: src/IceInst.cpp

Issue 1312433004: Weight variables by their number of uses for register allocation. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Tidy up lose ends. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 //===- subzero/src/IceInst.cpp - High-level instruction implementation ----===// 1 //===- subzero/src/IceInst.cpp - High-level instruction implementation ----===//
2 // 2 //
3 // The Subzero Code Generator 3 // The Subzero Code Generator
4 // 4 //
5 // This file is distributed under the University of Illinois Open Source 5 // This file is distributed under the University of Illinois Open Source
6 // License. See LICENSE.TXT for details. 6 // License. See LICENSE.TXT for details.
7 // 7 //
8 //===----------------------------------------------------------------------===// 8 //===----------------------------------------------------------------------===//
9 /// 9 ///
10 /// \file 10 /// \file
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 } 172 }
173 } 173 }
174 174
175 bool Inst::liveness(InstNumberT InstNumber, LivenessBV &Live, 175 bool Inst::liveness(InstNumberT InstNumber, LivenessBV &Live,
176 Liveness *Liveness, LiveBeginEndMap *LiveBegin, 176 Liveness *Liveness, LiveBeginEndMap *LiveBegin,
177 LiveBeginEndMap *LiveEnd) { 177 LiveBeginEndMap *LiveEnd) {
178 assert(!isDeleted()); 178 assert(!isDeleted());
179 179
180 Dead = false; 180 Dead = false;
181 if (Dest) { 181 if (Dest) {
182 // TODO(ascull): get the loop nest depth
183 Dest->addUse(1);
182 SizeT VarNum = Liveness->getLiveIndex(Dest->getIndex()); 184 SizeT VarNum = Liveness->getLiveIndex(Dest->getIndex());
183 if (Live[VarNum]) { 185 if (Live[VarNum]) {
184 if (!isDestNonKillable()) { 186 if (!isDestNonKillable()) {
185 Live[VarNum] = false; 187 Live[VarNum] = false;
186 if (LiveBegin && Liveness->getRangeMask(Dest->getIndex())) { 188 if (LiveBegin && Liveness->getRangeMask(Dest->getIndex())) {
187 LiveBegin->push_back(std::make_pair(VarNum, InstNumber)); 189 LiveBegin->push_back(std::make_pair(VarNum, InstNumber));
188 } 190 }
189 } 191 }
190 } else { 192 } else {
191 if (!hasSideEffects()) 193 if (!hasSideEffects())
192 Dead = true; 194 Dead = true;
193 } 195 }
194 } 196 }
195 if (Dead) 197 if (Dead)
196 return false; 198 return false;
197 // Phi arguments only get added to Live in the predecessor node, but 199 // Phi arguments only get added to Live in the predecessor node, but
198 // we still need to update LiveRangesEnded. 200 // we still need to update LiveRangesEnded.
199 bool IsPhi = llvm::isa<InstPhi>(this); 201 bool IsPhi = llvm::isa<InstPhi>(this);
200 resetLastUses(); 202 resetLastUses();
201 SizeT VarIndex = 0; 203 SizeT VarIndex = 0;
202 for (SizeT I = 0; I < getSrcSize(); ++I) { 204 for (SizeT I = 0; I < getSrcSize(); ++I) {
203 Operand *Src = getSrc(I); 205 Operand *Src = getSrc(I);
204 SizeT NumVars = Src->getNumVars(); 206 SizeT NumVars = Src->getNumVars();
205 for (SizeT J = 0; J < NumVars; ++J, ++VarIndex) { 207 for (SizeT J = 0; J < NumVars; ++J, ++VarIndex) {
206 const Variable *Var = Src->getVar(J); 208 Variable *Var = Src->getVar(J);
209 // TODO(ascull): get the loop nest depth
210 Var->addUse(1);
207 SizeT VarNum = Liveness->getLiveIndex(Var->getIndex()); 211 SizeT VarNum = Liveness->getLiveIndex(Var->getIndex());
208 if (!Live[VarNum]) { 212 if (!Live[VarNum]) {
209 setLastUse(VarIndex); 213 setLastUse(VarIndex);
210 if (!IsPhi) { 214 if (!IsPhi) {
211 Live[VarNum] = true; 215 Live[VarNum] = true;
212 // For a variable in SSA form, its live range can end at 216 // For a variable in SSA form, its live range can end at
213 // most once in a basic block. However, after lowering to 217 // most once in a basic block. However, after lowering to
214 // two-address instructions, we end up with sequences like 218 // two-address instructions, we end up with sequences like
215 // "t=b;t+=c;a=t" where t's live range begins and ends 219 // "t=b;t+=c;a=t" where t's live range begins and ends
216 // twice. ICE only allows a variable to have a single 220 // twice. ICE only allows a variable to have a single
(...skipping 757 matching lines...) Expand 10 before | Expand all | Expand 10 after
974 // preserve these. 978 // preserve these.
975 return true; 979 return true;
976 } 980 }
977 if (!Dest->hasReg() && !SrcVar->hasReg() && 981 if (!Dest->hasReg() && !SrcVar->hasReg() &&
978 Dest->getStackOffset() == SrcVar->getStackOffset()) 982 Dest->getStackOffset() == SrcVar->getStackOffset())
979 return true; 983 return true;
980 return false; 984 return false;
981 } 985 }
982 986
983 } // end of namespace Ice 987 } // end of namespace Ice
OLDNEW
« no previous file with comments | « src/IceCfgNode.cpp ('k') | src/IceLiveness.cpp » ('j') | src/IceOperand.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698