Weight variables by their number of uses for register allocation.

src/IceOperand.h

 //===- subzero/src/IceOperand.h - High-level operands -----------*- C++ -*-===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 314 matching lines @@
   const static uint32_t Zero = 0; /// Force regalloc NOT to give a register
   void addWeight(uint32_t Delta) {
     if (Delta == Inf)
       Weight = Inf;
     else if (Weight != Inf)
       Weight += Delta;
   }
   void addWeight(const RegWeight &Other) { addWeight(Other.Weight); }
   void setWeight(uint32_t Val) { Weight = Val; }
   uint32_t getWeight() const { return Weight; }
   bool isInf() const { return Weight == Inf; }

[jvoung (off chromium), 2015/08/26 21:45:46]

It looks like the isInf() method isn't used anymore. Remove?

[ascull, 2015/08/26 22:06:39]

Done.

   bool isZero() const { return Weight == Zero; }

[jvoung (off chromium), 2015/08/26 21:45:46]

similar for isZero

[ascull, 2015/08/26 22:06:39]

Done.

 
 private:
   uint32_t Weight = 0;
 };
 Ostream &operator<<(Ostream &Str, const RegWeight &W);
 bool operator<(const RegWeight &A, const RegWeight &B);
 bool operator<=(const RegWeight &A, const RegWeight &B);
 bool operator==(const RegWeight &A, const RegWeight &B);
 
+enum RegRequirement {

[jvoung (off chromium), 2015/08/26 21:45:47]

Should this enum be scoped in RegWeight? (near the Inf and Zero values)?

[ascull, 2015/08/26 22:06:39]

It is separate from RegWeight which is an 'infinity' capped integer. It is
however only used privately by Variable which is where I moved it. I was going
to use it in LiveRange too but I got rid of the weight there as it was
redundant.

+  ShouldHaveRegister,
+  MustHaveRegister,
+  MustNotHaveRegister,
+};
+
 /// LiveRange is a set of instruction number intervals representing
 /// a variable's live range.  Generally there is one interval per basic
 /// block where the variable is live, but adjacent intervals get
 /// coalesced into a single interval.  LiveRange also includes a
 /// weight, in case e.g. we want a live range to have higher weight

[jvoung (off chromium), 2015/08/26 21:45:46]

LiveRange doesn't include the weight field anymore?

[ascull, 2015/08/26 22:06:39]

Yes, the weight is managed by the Variable which, given SSA, is equivalent to a
live range. Removed this comment.

 /// inside a loop.
 class LiveRange {
 public:
   LiveRange() = default;
   /// Special constructor for building a kill set.  The advantage is
   /// that we can reserve the right amount of space in advance.
   explicit LiveRange(const std::vector<InstNumberT> &Kills) {
     Range.reserve(Kills.size());
     for (InstNumberT I : Kills)
       addSegment(I, I);
   }
   LiveRange(const LiveRange &) = default;
   LiveRange &operator=(const LiveRange &) = default;
 
   void reset() {
     Range.clear();
-    Weight.setWeight(0);
     untrim();
   }
   void addSegment(InstNumberT Start, InstNumberT End);
 
   bool endsBefore(const LiveRange &Other) const;
   bool overlaps(const LiveRange &Other, bool UseTrimmed = false) const;
   bool overlapsInst(InstNumberT OtherBegin, bool UseTrimmed = false) const;
   bool containsValue(InstNumberT Value, bool IsDest) const;
   bool isEmpty() const { return Range.empty(); }
   InstNumberT getStart() const {
     return Range.empty() ? -1 : Range.begin()->first;
   }
   InstNumberT getEnd() const {
     return Range.empty() ? -1 : Range.rbegin()->second;
   }
 
   void untrim() { TrimmedBegin = Range.begin(); }
   void trim(InstNumberT Lower);
 
-  RegWeight getWeight() const { return Weight; }
-  void setWeight(const RegWeight &NewWeight) { Weight = NewWeight; }
-  void addWeight(uint32_t Delta) { Weight.addWeight(Delta); }
   void dump(Ostream &Str) const;
 
 private:
   typedef std::pair<InstNumberT, InstNumberT> RangeElementType;
   /// RangeType is arena-allocated from the Cfg's allocator.
   typedef std::vector<RangeElementType, CfgLocalAllocator<RangeElementType>>
       RangeType;
   RangeType Range;
-  RegWeight Weight = RegWeight(0);
   /// TrimmedBegin is an optimization for the overlaps() computation.
   /// Since the linear-scan algorithm always calls it as overlaps(Cur)
   /// and Cur advances monotonically according to live range start, we
   /// can optimize overlaps() by ignoring all segments that end before
   /// the start of Cur's range.  The linear-scan code enables this by
   /// calling trim() on the ranges of interest as Cur advances.  Note
   /// that linear-scan also has to initialize TrimmedBegin at the
   /// beginning by calling untrim().
   RangeType::const_iterator TrimmedBegin;
 };
@@ skipping 38 matching lines @@
   int32_t getRegNum() const { return RegNum; }
   void setRegNum(int32_t NewRegNum) {
     // Regnum shouldn't be set more than once.
     assert(!hasReg() || RegNum == NewRegNum);
     RegNum = NewRegNum;
   }
   bool hasRegTmp() const { return getRegNumTmp() != NoRegister; }
   int32_t getRegNumTmp() const { return RegNumTmp; }
   void setRegNumTmp(int32_t NewRegNum) { RegNumTmp = NewRegNum; }
 
-  RegWeight getWeight() const { return Weight; }
-  void setWeight(uint32_t NewWeight) { Weight = RegWeight(NewWeight); }
-  void setWeightInfinite() { setWeight(RegWeight::Inf); }
+  RegWeight getWeight() const {
+    return RegWeight(mustHaveReg() ? RegWeight::Inf : mustNotHaveReg()
+                                                          ? RegWeight::Zero
+                                                          : UseWeight);
+  }
+  void resetUses() { UseWeight = 0; }
+  void addUse(uint32_t Weight) { UseWeight += Weight; }
+
+  void setMustHaveReg() { RegRequirement = MustHaveRegister; }
+  bool mustHaveReg() const { return RegRequirement == MustHaveRegister; }
+  void setMustNotHaveReg() { RegRequirement = MustNotHaveRegister; }
+  bool mustNotHaveReg() const { return RegRequirement == MustNotHaveRegister; }
 
   LiveRange &getLiveRange() { return Live; }
   const LiveRange &getLiveRange() const { return Live; }
   void setLiveRange(const LiveRange &Range) { Live = Range; }
-  void resetLiveRange() { Live.reset(); }
+  void resetLiveRange() {
+    Live.reset();
+    resetUses();
+  }
   void addLiveRange(InstNumberT Start, InstNumberT End, uint32_t WeightDelta) {
     assert(!getIgnoreLiveness());
     assert(WeightDelta != RegWeight::Inf);

[jvoung (off chromium), 2015/08/26 21:45:46]

WeightDelta is only used in assert builds now and looks like it's always 1.
Should that just be removed?

[ascull, 2015/08/26 22:06:39]

Done.

     Live.addSegment(Start, End);
-    if (Weight.isInf())
-      Live.setWeight(RegWeight(RegWeight::Inf));
-    else
-      Live.addWeight(WeightDelta * Weight.getWeight());
-  }
-  void setLiveRangeInfiniteWeight() {
-    Live.setWeight(RegWeight(RegWeight::Inf));
   }
   void trimLiveRange(InstNumberT Start) { Live.trim(Start); }
   void untrimLiveRange() { Live.untrim(); }
   bool rangeEndsBefore(const Variable *Other) const {
     return Live.endsBefore(Other->Live);
   }
   bool rangeOverlaps(const Variable *Other) const {
     const bool UseTrimmed = true;
     return Live.overlaps(Other->Live, UseTrimmed);
   }
   bool rangeOverlapsStart(const Variable *Other) const {
     const bool UseTrimmed = true;
     return Live.overlapsInst(Other->Live.getStart(), UseTrimmed);
   }
 
   Variable *getLo() const { return LoVar; }
   Variable *getHi() const { return HiVar; }
   void setLoHi(Variable *Lo, Variable *Hi) {
     assert(LoVar == nullptr);
     assert(HiVar == nullptr);
     LoVar = Lo;
     HiVar = Hi;
   }
   /// Creates a temporary copy of the variable with a different type.
   /// Used primarily for syntactic correctness of textual assembly
   /// emission.  Note that only basic information is copied, in
   /// particular not IsArgument, IsImplicitArgument, IgnoreLiveness,
   /// RegNumTmp, Weight, Live, LoVar, HiVar, VarsReal.

[jvoung (off chromium), 2015/08/26 21:45:46]

Weight -> UseWeight ?

[ascull, 2015/08/26 22:06:39]

UseWeight -> Weight. Missed this refactor.

   Variable *asType(Type Ty);
 
   void emit(const Cfg *Func) const override;
   using Operand::dump;
   void dump(const Cfg *Func, Ostream &Str) const override;
 
   /// Return reg num of base register, if different from stack/frame register.
   virtual int32_t getBaseRegNum() const { return NoRegister; }
 
   static bool classof(const Operand *Operand) {
@@ skipping 19 matching lines @@
   /// reserved for the stack pointer.
   bool IgnoreLiveness = false;
   /// StackOffset is the canonical location on stack (only if
   /// RegNum==NoRegister || IsArgument).
   int32_t StackOffset = 0;
   /// RegNum is the allocated register, or NoRegister if it isn't
   /// register-allocated.
   int32_t RegNum = NoRegister;
   /// RegNumTmp is the tentative assignment during register allocation.
   int32_t RegNumTmp = NoRegister;
-  RegWeight Weight = RegWeight(1); // Register allocation priority
+  /// \name Register allocation priority
+  /// @{
+  uint32_t UseWeight = 0; /// Calculated by use count and loop nest depth.
+  RegRequirement RegRequirement = ShouldHaveRegister;
+  /// @}
   LiveRange Live;
   // LoVar and HiVar are needed for lowering from 64 to 32 bits.  When
   // lowering from I64 to I32 on a 32-bit architecture, we split the
   // variable into two machine-size pieces.  LoVar is the low-order
   // machine-size portion, and HiVar is the remaining high-order
   // portion.  TODO: It's wasteful to penalize all variables on all
   // targets this way; use a sparser representation.  It's also
   // wasteful for a 64-bit target.
   Variable *LoVar = nullptr;
   Variable *HiVar = nullptr;
@@ skipping 102 matching lines @@
 private:
   const Cfg *Func;
   MetadataKind Kind;
   std::vector<VariableTracking> Metadata;
   const static InstDefList NoDefinitions;
 };
 
 } // end of namespace Ice
 
 #endif // SUBZERO_SRC_ICEOPERAND_H