Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 131243003: Turn Runtime_MigrateInstance into Runtime_TryMigrateInstance (Closed)

Created:
6 years, 11 months ago by Jakob Kummerow
Modified:
6 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev, titzer
Visibility:
Public.

Description

Turn Runtime_MigrateInstance into Runtime_TryMigrateInstance because it must not cause lazy deopts because it is called from deferred code that cannot handle lazy deopts. Hat tip to Ben for doing most of the debugging work, and to Toon for writing the regression test. BUG=chromium:315252 LOG=Y R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18586

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -28 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.h View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-315252.js View 1 chunk +30 lines, -21 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
Toon: PTAL. Ben: FYI.
6 years, 11 months ago (2014-01-14 13:13:58 UTC) #1
Toon Verwaest
lgtm, thanks
6 years, 11 months ago (2014-01-14 13:38:39 UTC) #2
Jakob Kummerow
6 years, 11 months ago (2014-01-14 13:41:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18586 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698