Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1767)

Unified Diff: Source/platform/graphics/paint/DisplayItemList.cpp

Issue 1312423006: Remove dependency on m_previousPositionFromPaintInvalidationBacking for spv2 (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update TestExpectations Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/graphics/paint/DisplayItemList.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/graphics/paint/DisplayItemList.cpp
diff --git a/Source/platform/graphics/paint/DisplayItemList.cpp b/Source/platform/graphics/paint/DisplayItemList.cpp
index 4f990f6f4dfd51482d297bfec7cf7a1a1e662e1f..dcdec339b834d8035035fb40538847da4d8de6f4 100644
--- a/Source/platform/graphics/paint/DisplayItemList.cpp
+++ b/Source/platform/graphics/paint/DisplayItemList.cpp
@@ -142,20 +142,23 @@ bool DisplayItemList::clientCacheIsValid(DisplayItemClient client) const
return m_validlyCachedClients.contains(client);
}
-void DisplayItemList::invalidatePaintOffset(DisplayItemClient client)
+void DisplayItemList::invalidatePaintOffset(const DisplayItemClientWrapper& client)
{
ASSERT(RuntimeEnabledFeatures::slimmingPaintV2Enabled());
updateValidlyCachedClientsIfNeeded();
- m_validlyCachedClients.remove(client);
+ m_validlyCachedClients.remove(client.displayItemClient());
+
+ if (RuntimeEnabledFeatures::slimmingPaintV2Enabled() && m_trackedPaintInvalidationObjects)
+ m_trackedPaintInvalidationObjects->append(client.debugName());
#if ENABLE(ASSERT)
- m_clientsWithPaintOffsetInvalidations.add(client);
+ m_clientsWithPaintOffsetInvalidations.add(client.displayItemClient());
// Ensure no phases slipped in using the old paint offset which would indicate
// different phases used different paint offsets, which should not happen.
for (const auto& item : m_newDisplayItems)
- ASSERT(!item.isCached() || item.client() != client);
+ ASSERT(!item.isCached() || item.client() != client.displayItemClient());
#endif
}
« no previous file with comments | « Source/platform/graphics/paint/DisplayItemList.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698