Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1312393004: Devtools UI: Fix Chrome focus shortcut and add pause debugger shortcut (Closed)

Created:
5 years, 3 months ago by samli
Modified:
5 years, 3 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools UI: Fix Chrome focus shortcut and add pause debugger shortcut This change reverts adding Cmd+L clear console shortcut, as it conflicts with Chrome's omnibox focus shortcut on Mac. This change also allows the pause script shortcuts to be used while inside the inspected page, allowing the user to perform a series of mouse/focus actions before pausing script. BUG=527220 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201672

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/devtools/front_end/console/module.json View 1 1 chunk +1 line, -1 line 2 comments Download
M Source/devtools/front_end/main/Main.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
samli
5 years, 3 months ago (2015-09-01 23:25:23 UTC) #2
pfeldman
https://codereview.chromium.org/1312393004/diff/1/Source/devtools/front_end/console/module.json File Source/devtools/front_end/console/module.json (left): https://codereview.chromium.org/1312393004/diff/1/Source/devtools/front_end/console/module.json#oldcode45 Source/devtools/front_end/console/module.json:45: "shortcut": "Ctrl+L Meta+L" Cmd + K used to clear ...
5 years, 3 months ago (2015-09-02 02:39:22 UTC) #3
samli
https://codereview.chromium.org/1312393004/diff/1/Source/devtools/front_end/console/module.json File Source/devtools/front_end/console/module.json (left): https://codereview.chromium.org/1312393004/diff/1/Source/devtools/front_end/console/module.json#oldcode45 Source/devtools/front_end/console/module.json:45: "shortcut": "Ctrl+L Meta+L" On 2015/09/02 at 02:39:22, pfeldman wrote: ...
5 years, 3 months ago (2015-09-02 19:07:48 UTC) #4
pfeldman
lgtm https://codereview.chromium.org/1312393004/diff/20001/Source/devtools/front_end/console/module.json File Source/devtools/front_end/console/module.json (right): https://codereview.chromium.org/1312393004/diff/20001/Source/devtools/front_end/console/module.json#newcode45 Source/devtools/front_end/console/module.json:45: "shortcut": "Ctrl+L Meta+K" I don't think it was ...
5 years, 3 months ago (2015-09-02 20:11:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312393004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312393004/20001
5 years, 3 months ago (2015-09-02 21:17:38 UTC) #7
samli
https://codereview.chromium.org/1312393004/diff/20001/Source/devtools/front_end/console/module.json File Source/devtools/front_end/console/module.json (right): https://codereview.chromium.org/1312393004/diff/20001/Source/devtools/front_end/console/module.json#newcode45 Source/devtools/front_end/console/module.json:45: "shortcut": "Ctrl+L Meta+K" On 2015/09/02 at 20:11:16, pfeldman wrote: ...
5 years, 3 months ago (2015-09-02 21:17:50 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 22:16:58 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201672

Powered by Google App Engine
This is Rietveld 408576698