Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 1312363003: Do not trigger compositing update on selection gap update for SPv2 (Closed)

Created:
5 years, 4 months ago by trchen
Modified:
5 years, 3 months ago
Reviewers:
chrishtr, wkorman
CC:
blink-reviews, blink-reviews-paint_chromium.org, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Do not trigger compositing update on selection gap update for SPv2 Doing so results in assertion failure because the document lifecycle does not allow rewinding from InPaintForSlimmingPaintV2 back to LayoutClean. Skipping compositing update should be fine since SPv2 doesn't rely on old world compositing anyway. BUG=524879 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201244

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/core/paint/DeprecatedPaintLayer.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
trchen
5 years, 4 months ago (2015-08-26 05:16:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312363003/1
5 years, 4 months ago (2015-08-26 05:16:52 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-26 06:41:00 UTC) #6
wkorman
lgtm
5 years, 3 months ago (2015-08-26 17:51:53 UTC) #7
chrishtr
lgtm
5 years, 3 months ago (2015-08-26 18:26:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312363003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312363003/1
5 years, 3 months ago (2015-08-26 20:10:16 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 20:16:47 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201244

Powered by Google App Engine
This is Rietveld 408576698