(Reland) Make m_executeScriptsWaitingForResourcesTimer a loading task

Make m_executeScriptsWaitingForResourcesTimer a loading task

We would like to be able to prioritize loading tasks, but in order to
do that we need to make sure loading tasks are posted to the right queue
to make sure tasks run in the expected order.  If this task is posted as
a timer, and loading tasks are prioritzed, it's possible
FrameHostMsg_DidStopLoading will be sent before the corresponding
FrameHostMsg_DidStartLoading ipc which causes various browser tests to
break.

BUG=497761, 510398
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201563

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201654

[alex clarke (OOO till 29th), 2015-09-01 09:29:44]

alexclarke@chromium.org changed reviewers:
+ skyostil@chromium.org

[alex clarke (OOO till 29th), 2015-09-01 09:30:44]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-01 09:30:56]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312353004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312353004/1

[Sami, 2015-09-01 09:31:35]

lgtm with a nit.

https://codereview.chromium.org/1312353004/diff/1/Source/core/dom/Document.h
File Source/core/dom/Document.h (right):

https://codereview.chromium.org/1312353004/diff/1/Source/core/dom/Document.h#...
Source/core/dom/Document.h:1126: void
executeScriptsWaitingForResourcesTimerFired();
s/TimerFired//?

[alex clarke (OOO till 29th), 2015-09-01 09:37:56]

alexclarke@chromium.org changed reviewers:
+ mkwst@chromium.org

[alex clarke (OOO till 29th), 2015-09-01 09:37:57]

+mkwst@ Can you please review this too?

Thanks!

https://codereview.chromium.org/1312353004/diff/1/Source/core/dom/Document.h
File Source/core/dom/Document.h (right):

https://codereview.chromium.org/1312353004/diff/1/Source/core/dom/Document.h#...
Source/core/dom/Document.h:1126: void
executeScriptsWaitingForResourcesTimerFired();
On 2015/09/01 09:31:35, Sami wrote:
> s/TimerFired//?

Done.

[Mike West, 2015-09-01 16:09:22]

LGTM

[alex clarke (OOO till 29th), 2015-09-01 16:12:32]

The CQ bit was checked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2015-09-01 16:12:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/1312353004/#ps20001
(title: "Rename")

[commit-bot: I haz the power, 2015-09-01 16:12:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312353004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312353004/20001

[commit-bot: I haz the power, 2015-09-01 17:24:51]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201563

[alex clarke (OOO till 29th), 2015-09-02 13:01:33]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1304943004/ by alexclarke@chromium.org.

The reason for reverting is: Oilpan leaks..

[sof, 2015-09-02 13:58:46]

sigbjornf@opera.com changed reviewers:
+ sigbjornf@opera.com

[sof, 2015-09-02 13:58:47]

https://codereview.chromium.org/1312353004/diff/20001/Source/core/dom/Documen...
File Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/1312353004/diff/20001/Source/core/dom/Documen...
Source/core/dom/Document.cpp:366: 
Add 

} // namespace blink

namespace WTF {
template<>
struct PointerParamStorageTraits<blink::Document*, true> {
    using StorageType = blink::CrossThreadWeakPersistent<blink::Document>;

    static StorageType wrap(blink::Document* value) { return value; }
    static blink::Document* unwrap(const StorageType& value) { return
value.get(); }
};

} // namespace WTF

namespace blink {

here to avoid introducing a leak with Oilpan enabled.

[blink-reviews, 2015-09-02 14:01:02]

That's really awesome and scary at the same time!  Thanks ever so much for
fixing that :)

On Wed, Sep 2, 2015 at 2:58 PM, <sigbjornf@opera.com> wrote:

>
>
>
https://codereview.chromium.org/1312353004/diff/20001/Source/core/dom/Documen...
> File Source/core/dom/Document.cpp (right):
>
>
>
https://codereview.chromium.org/1312353004/diff/20001/Source/core/dom/Documen...
> Source/core/dom/Document.cpp:366:
> Add
>
> } // namespace blink
>
> namespace WTF {
> template<>
> struct PointerParamStorageTraits<blink::Document*, true> {
>     using StorageType =
> blink::CrossThreadWeakPersistent<blink::Document>;
>
>     static StorageType wrap(blink::Document* value) { return value; }
>     static blink::Document* unwrap(const StorageType& value) { return
> value.get(); }
> };
>
> } // namespace WTF
>
> namespace blink {
>
> here to avoid introducing a leak with Oilpan enabled.
>
> https://codereview.chromium.org/1312353004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[alex clarke (OOO till 29th), 2015-09-02 14:21:41]

https://codereview.chromium.org/1312353004/diff/20001/Source/core/dom/Documen...
File Source/core/dom/Document.cpp (right):

https://codereview.chromium.org/1312353004/diff/20001/Source/core/dom/Documen...
Source/core/dom/Document.cpp:366: 
On 2015/09/02 13:58:47, sof wrote:
> Add 
> 
> } // namespace blink
> 
> namespace WTF {
> template<>
> struct PointerParamStorageTraits<blink::Document*, true> {
>     using StorageType = blink::CrossThreadWeakPersistent<blink::Document>;
> 
>     static StorageType wrap(blink::Document* value) { return value; }
>     static blink::Document* unwrap(const StorageType& value) { return
> value.get(); }
> };
> 
> } // namespace WTF
> 
> namespace blink {
> 
> here to avoid introducing a leak with Oilpan enabled.

Done, and thanks!

[alex clarke (OOO till 29th), 2015-09-02 14:22:14]

The CQ bit was checked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2015-09-02 14:22:15]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org,
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/1312353004/#ps40001
(title: "Oilpan leak fix")

[commit-bot: I haz the power, 2015-09-02 14:22:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312353004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312353004/40001

[commit-bot: I haz the power, 2015-09-02 14:33:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-02 14:33:59]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[alex clarke (OOO till 29th), 2015-09-02 16:06:48]

The CQ bit was checked by alexclarke@chromium.org

[alex clarke (OOO till 29th), 2015-09-02 16:06:48]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org,
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/1312353004/#ps60001
(title: "Add #if ENABLE(OILPAN)")

[commit-bot: I haz the power, 2015-09-02 16:07:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312353004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312353004/60001

[commit-bot: I haz the power, 2015-09-02 17:34:06]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201654