Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.cc

Issue 1312343003: Append playinline=chrome_inline to the store referrer on native app banner install. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix tests not caught by trybots Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/banners/app_banner_manager_android.cc
diff --git a/chrome/browser/android/banners/app_banner_manager_android.cc b/chrome/browser/android/banners/app_banner_manager_android.cc
index 953c0e934e4eca9adaf4821cb644dc182130c3fd..80e5e6cc99f4b4c6f0b8e5b4066f03adb17cb3a5 100644
--- a/chrome/browser/android/banners/app_banner_manager_android.cc
+++ b/chrome/browser/android/banners/app_banner_manager_android.cc
@@ -25,6 +25,7 @@ namespace {
const char kPlayPlatform[] = "play";
const char kReferrerName[] = "referrer";
const char kIdName[] = "id";
+const char kPlayInlineReferrer[] = "playinline=chrome_inline";
} // anonymous namespace
@@ -73,7 +74,15 @@ bool AppBannerManagerAndroid::HandleNonWebApp(const std::string& platform,
return false;
}
- std::string referrer = ExtractQueryValueForName(url, kReferrerName);
+ std::string referrer =
+ ExtractQueryValueForName(url, kReferrerName);
+
+ // Attach the chrome_inline referrer value, prefixed with "&" if the referrer
+ // is non empty.
+ if (referrer.empty())
+ referrer = kPlayInlineReferrer;
+ else
+ referrer.append("&").append(kPlayInlineReferrer);
ScopedJavaLocalRef<jstring> jurl(
ConvertUTF8ToJavaString(env, data_fetcher()->validated_url().spec()));
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698