Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1312343003: Append playinline=chrome_inline to the store referrer on native app banner install. (Closed)

Created:
5 years, 4 months ago by dominickn
Modified:
5 years, 3 months ago
Reviewers:
gone
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Append playinline=chrome_inline to the store referrer on native app banner install. This CL appends a marker to the store referrer to show that a native app install was triggered from the Chrome inline flow. This marker is always sent to the store, even if the site triggering an install does not specify a referrer. BUG=503226 Committed: https://crrev.com/e55eabaaa89d6b01dd5ab9984b6d670468ca9e72 Cr-Commit-Position: refs/heads/master@{#345730} Committed: https://crrev.com/387ab8c30b11396615b8c3c5b56d058e947c1ae8 Cr-Commit-Position: refs/heads/master@{#346030}

Patch Set 1 : #

Patch Set 2 : Properly handle appending & #

Patch Set 3 : Fix tests not caught by trybots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/android/banners/app_banner_manager_android.cc View 1 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
dominickn
PTAL, thanks!
5 years, 3 months ago (2015-08-26 13:29:07 UTC) #4
gone
lgtm
5 years, 3 months ago (2015-08-26 19:01:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312343003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312343003/60001
5 years, 3 months ago (2015-08-26 23:58:04 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 3 months ago (2015-08-27 00:06:06 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e55eabaaa89d6b01dd5ab9984b6d670468ca9e72 Cr-Commit-Position: refs/heads/master@{#345730}
5 years, 3 months ago (2015-08-27 00:07:16 UTC) #9
Nico
A revert of this CL (patchset #2 id:60001) has been created in https://codereview.chromium.org/1308713007/ by thakis@chromium.org. ...
5 years, 3 months ago (2015-08-27 06:28:09 UTC) #10
gone
lgtm again
5 years, 3 months ago (2015-08-27 18:37:05 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312343003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312343003/100001
5 years, 3 months ago (2015-08-27 23:57:25 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:100001)
5 years, 3 months ago (2015-08-28 00:02:41 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 00:03:14 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/387ab8c30b11396615b8c3c5b56d058e947c1ae8
Cr-Commit-Position: refs/heads/master@{#346030}

Powered by Google App Engine
This is Rietveld 408576698