Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1312333005: Remove FormDataList::Entry. (Closed)

Created:
5 years, 3 months ago by tkent
Modified:
5 years, 3 months ago
Reviewers:
keishi
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove FormDataList::Entry. Fold FormDataList::getEntry() and getAll() into DOMFormData. So, no one uses FormDataList::Entry. This CL has no behavior changes. BUG=528840 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201966

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -92 lines) Patch
M Source/core/html/DOMFormData.cpp View 2 chunks +21 lines, -16 lines 0 comments Download
M Source/core/html/DOMFormDataTest.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
M Source/core/html/FormDataList.h View 3 chunks +0 lines, -31 lines 0 comments Download
M Source/core/html/FormDataList.cpp View 2 chunks +0 lines, -41 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
tkent
Keishi, please review this.
5 years, 3 months ago (2015-09-09 08:21:56 UTC) #2
keishi
lgtm
5 years, 3 months ago (2015-09-09 08:35:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312333005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312333005/1
5 years, 3 months ago (2015-09-09 08:38:53 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/109056)
5 years, 3 months ago (2015-09-09 08:43:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312333005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312333005/1
5 years, 3 months ago (2015-09-09 08:52:13 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/67003) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-09-09 08:54:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312333005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312333005/1
5 years, 3 months ago (2015-09-09 08:57:43 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/67007) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 3 months ago (2015-09-09 08:59:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312333005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312333005/1
5 years, 3 months ago (2015-09-09 09:52:43 UTC) #17
commit-bot: I haz the power
5 years, 3 months ago (2015-09-09 10:00:07 UTC) #18
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201966

Powered by Google App Engine
This is Rietveld 408576698