Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Unified Diff: sdk/lib/_internal/pub/lib/src/barback/server.dart

Issue 131233011: Set the correct mime types for assets served via pub serve. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/lib/src/barback/server.dart
diff --git a/sdk/lib/_internal/pub/lib/src/barback/server.dart b/sdk/lib/_internal/pub/lib/src/barback/server.dart
index d285cfad3e978b42c3cf1a08422ee316f8ee9203..0ecd417d0c8d313a06637df0811eb0cfb4233465 100644
--- a/sdk/lib/_internal/pub/lib/src/barback/server.dart
+++ b/sdk/lib/_internal/pub/lib/src/barback/server.dart
@@ -9,6 +9,7 @@ import 'dart:convert';
import 'dart:io';
import 'package:barback/barback.dart';
+import 'package:mime/mime.dart';
import 'package:path/path.dart' as path;
import 'package:stack_trace/stack_trace.dart';
@@ -114,6 +115,7 @@ class BarbackServer {
return validateStream(asset.read()).then((stream) {
_resultsController.add(
new BarbackServerResult._success(request.uri, id));
+ request.response.headers.add('content-type', lookupMimeType(id.path));
Bob Nystrom 2014/02/11 19:11:14 Hurray for code reuse!
// TODO(rnystrom): Set content-type based on asset type.
return Chain.track(request.response.addStream(stream)).then((_) {
// Log successful requests both so we can provide debugging

Powered by Google App Engine
This is Rietveld 408576698