Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 131233008: Revert 248285 "Roll DEPS for gtest library." (Closed)

Created:
6 years, 10 months ago by Avi (use Gerrit)
Modified:
6 years, 10 months ago
Reviewers:
tfarina, Nico, kosak
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 248285 "Roll DEPS for gtest library." The Android bots are exploding, failing every test. http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/18272 http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/11653 That is highly unusual behavior, so I'm blaming the DEPS roll for the test library for now. > Roll DEPS for gtest library. > > From r643 to r677. > > r644: Supports colored output on term type screen-256color. > r645: Prints a useful message when GetParam() is called in a non-parameterized test. > r646: Replaces unportable == with portable = in configure.ac. > r647: Fixes some compatibility issues with STLport. > r648: Implements support for calling Test::RecordProperty() outside of a test. > r649: Updates the list of reserved properties for RecordProperty. > r651: Updates the version number to 1.7.0 > r652: prints type/value parameters when listing tests > r653: Fixes a thread annotation; updates CHANGES for 1.7.0 > r654: When --gtest_filter is specified, XML report now doesn't contain information > r655: Fixes compatibility with C++11: (1 - 1) is no longer a NULL pointer constant. > r657: makes gtest-death-test_test.cc compile on platforms that don't support death > tests; > r658: allows gtest-config.in to work with an absoulte path for @top_srcdir@. > r659: fixes a typo in CMake script; h/t to Jay Mueller for reporting the issue > r661: Updates gtest.xcodeproj to be compatible with OS X 10.8.4 & Xcode 4.6.3 > r662: supports a protocol for catching tests that prematurely exit > r663: avoids clash with the max() macro on Windows > r664: Cuts release 1.7.0 > r668: Delete whitespace, and change the return type of > ImplicitlyConvertible::MakeFrom() to From&. > r669: Add MemorySanitizer annotations in gtest printers. Also remove unused variable > kPathSeparatorString. > r670: Fix warnings encountered with clang -Wall. > r671: Distinguish between C++11 language and library support for <initializer_list>. > r672: Improves documentation on gtest's macros. > r673: Define specialization of PrintTo(...) for ::std::tuple. > r674: Fix a couple of typos in Google Test's README. > r675: Make Google Test build cleanly on Visual Studio 2010, 2012, 2013. > r676: Add GTEST_MOVE macro, to support mocking methods with move-only return types. > r677: Suppress "Conditional expression is constant" warning on Visual Studio. > > BUG=None > TEST=None > R=thakis@chromium.org > > Review URL: https://codereview.chromium.org/149243010 TBR=tfarina@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248302

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M trunk/src/DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
6 years, 10 months ago (2014-01-31 23:47:27 UTC) #1
Avi (use Gerrit)
Committed patchset #1 manually as r248302.
6 years, 10 months ago (2014-01-31 23:47:33 UTC) #2
tfarina
OK! Nico, Kosak, fyi!
6 years, 10 months ago (2014-01-31 23:53:11 UTC) #3
Avi (use Gerrit)
6 years, 10 months ago (2014-02-01 01:10:14 UTC) #4
It looks like that gtest roll was the cause, since the Android bots went
green after the revert.

What seems to have broken was that tests got classified as unknown:

C  171s Main

********************************************************************************
C  171s Main  Summary
C  171s Main

********************************************************************************
C  171s Main  ALL (3811 tests)
C  171s Main  PASS (3699 tests)
C  171s Main  FAIL (0 tests): []
C  171s Main  CRASH (0 tests): []
C  171s Main  TIMEOUT (0 tests): []
C  171s Main  UNKNOWN (112 tests): [//*, //*/whate[...]google.com]
C  171s Main

********************************************************************************

Something seems to have broken in parsing test output, and only on Android.

Good luck in figuring it out.



On Fri, Jan 31, 2014 at 6:53 PM, <tfarina@chromium.org> wrote:

> OK!
>
> Nico, Kosak, fyi!
>
> https://codereview.chromium.org/131233008/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698