Issue 1312313002: Fix clang/win build after https://codereview.chromium.org/1284053004/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1312313002: Fix clang/win build after https://codereview.chromium.org/1284053004/ (Closed)

Created:
5 years, 4 months ago by Nico

Modified:
5 years, 3 months ago

Reviewers:
charliea (OOO until 10-5)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix clang/win build after https://codereview.chromium.org/1284053004/ The change removed a function, but not its declaration, angering -Wunused-function. BUG=345845, 82385 TBR=charliea

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	base/time/time_win.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 5 (1 generated)

Nico

Committed patchset #1 (id:1) to pending queue manually as 7f214df6c16ff41c479ae89acbf0e3bf540e6d66 (presubmit successful).

5 years, 4 months ago (2015-08-25 22:32:42 UTC) #3

charliea (OOO until 10-5)

5 years, 3 months ago (2015-08-26 14:35:27 UTC) #5

Message was sent while issue was closed.

On 2015/08/25 23:15:50, danakj wrote:
> Thank you!

Gah, sorry about that. Thanks Nico.

lgtm