webkit/plugins/ppapi/ppb_video_decoder_impl.cc - Issue 13123003: Flash: Don't lose a reference to the Graphics3D from the VideoDecoder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/ppapi/ppb_video_decoder_impl.cc

Issue 13123003: Flash: Don't lose a reference to the Graphics3D from the VideoDecoder. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/plugins/ppapi/ppb_video_decoder_impl.cc

diff --git a/webkit/plugins/ppapi/ppb_video_decoder_impl.cc b/webkit/plugins/ppapi/ppb_video_decoder_impl.cc

index f1f7ed216d6e73ceb62914228796431652cfa0c6..c05329b3ef23068c491c956c8978cb9cda50c26d 100644

--- a/webkit/plugins/ppapi/ppb_video_decoder_impl.cc

+++ b/webkit/plugins/ppapi/ppb_video_decoder_impl.cc

@@ -206,11 +206,10 @@ int32_t PPB_VideoDecoder_Impl::Reset(scoped_refptr<TrackedCallback> callback) {

}

void PPB_VideoDecoder_Impl::Destroy() {

- if (!platform_video_decoder_.get())

- return;

+ if (platform_video_decoder_)

+ platform_video_decoder_.release()->Destroy();

FlushCommandBuffer();

- platform_video_decoder_.release()->Destroy();

::ppapi::PPB_VideoDecoder_Shared::Destroy();

ppp_videodecoder_ = NULL;

danakj 2013/03/27 22:56:04 I'll move this above too. "Clean up the subclass b

}