mojo/devtools/common/android_stack_parser/symbol.py - Issue 1312283003: Allow several build directories to be specified to search for symbols

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/devtools/common/android_stack_parser/symbol.py

Issue 1312283003: Allow several build directories to be specified to search for symbols (Closed) Base URL: git@github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/devtools/common/android_stack_parser/symbol.py

diff --git a/mojo/devtools/common/android_stack_parser/symbol.py b/mojo/devtools/common/android_stack_parser/symbol.py

index 797326c402ea9fb8730aa6f6f9a86d7594be14db..a0ae6a038fd1adbe0c84058e0d5229bdbc901105 100644

--- a/mojo/devtools/common/android_stack_parser/symbol.py

+++ b/mojo/devtools/common/android_stack_parser/symbol.py

@@ -25,7 +25,7 @@ import subprocess

import zipfile

NDK_DIR = ""

-BUILD_DIR = ""

+BUILD_DIRS = []

SYMBOLS_DIR = ""

ARCH = "arm"

@@ -190,7 +190,7 @@ def GetCandidates(filepart, candidate_fun, relative_dirs=None):

Returns:

A list of candidate files ordered by modification time, newest first.

"""

- candidates = [BUILD_DIR]

+ candidates = list(BUILD_DIRS)

if relative_dirs:

candidates = PathListJoin(candidates, relative_dirs)

« no previous file with comments | « mojo/devtools/common/android_stack_parser/stack ('k') | mojo/devtools/common/mojo_debug » ('j') | no next file with comments »