Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: mojo/devtools/common/android_stack_parser/symbol.py

Issue 1312283003: Allow several build directories to be specified to search for symbols (Closed) Base URL: git@github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« mojo/devtools/common/android_stack_parser/stack ('K') | « mojo/devtools/common/android_stack_parser/stack ('k') | mojo/devtools/common/mojo_debug » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/devtools/common/android_stack_parser/symbol.py
diff --git a/mojo/devtools/common/android_stack_parser/symbol.py b/mojo/devtools/common/android_stack_parser/symbol.py
index 797326c402ea9fb8730aa6f6f9a86d7594be14db..854abb55734ae3670071f154dec2e8d78e2600bc 100644
--- a/mojo/devtools/common/android_stack_parser/symbol.py
+++ b/mojo/devtools/common/android_stack_parser/symbol.py
@@ -25,7 +25,7 @@ import subprocess
import zipfile
NDK_DIR = ""
-BUILD_DIR = ""
+BUILD_DIRS = []
SYMBOLS_DIR = ""
ARCH = "arm"
@@ -190,7 +190,7 @@ def GetCandidates(filepart, candidate_fun, relative_dirs=None):
Returns:
A list of candidate files ordered by modification time, newest first.
"""
- candidates = [BUILD_DIR]
+ candidates = BUILD_DIRS[:]
ppi 2015/08/27 15:25:59 nit: list(BUILD_DIR) is more explicit in expressin
etiennej 2015/08/27 15:29:55 Done.
if relative_dirs:
candidates = PathListJoin(candidates, relative_dirs)
« mojo/devtools/common/android_stack_parser/stack ('K') | « mojo/devtools/common/android_stack_parser/stack ('k') | mojo/devtools/common/mojo_debug » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698