Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1312283003: Allow several build directories to be specified to search for symbols (Closed)

Created:
5 years, 3 months ago by etiennej
Modified:
5 years, 3 months ago
Reviewers:
ppi
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Allow several build directories to be specified to search for symbols Address the `device stack` part of domokit/devtools#38. R=ppi@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c66af0d5b43b7725c9c77559bd25c03119c5d8dc

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M mojo/devtools/common/android_stack_parser/stack View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/devtools/common/android_stack_parser/symbol.py View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/devtools/common/mojo_debug View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
etiennej
5 years, 3 months ago (2015-08-27 15:19:45 UTC) #2
ppi
lgtm https://codereview.chromium.org/1312283003/diff/1/mojo/devtools/common/android_stack_parser/stack File mojo/devtools/common/android_stack_parser/stack (right): https://codereview.chromium.org/1312283003/diff/1/mojo/devtools/common/android_stack_parser/stack#newcode147 mojo/devtools/common/android_stack_parser/stack:147: print "Reading Mojo symbols from", symbol.BUILD_DIRS Drop "Mojo"? ...
5 years, 3 months ago (2015-08-27 15:25:59 UTC) #3
etiennej
https://codereview.chromium.org/1312283003/diff/1/mojo/devtools/common/android_stack_parser/stack File mojo/devtools/common/android_stack_parser/stack (right): https://codereview.chromium.org/1312283003/diff/1/mojo/devtools/common/android_stack_parser/stack#newcode147 mojo/devtools/common/android_stack_parser/stack:147: print "Reading Mojo symbols from", symbol.BUILD_DIRS On 2015/08/27 15:25:59, ...
5 years, 3 months ago (2015-08-27 15:29:55 UTC) #4
etiennej
5 years, 3 months ago (2015-08-27 15:31:49 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
c66af0d5b43b7725c9c77559bd25c03119c5d8dc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698