NaCl: Re-enable ASLR for nacl-loader processes on Mac OS X

NaCl: Re-enable ASLR for nacl-loader processes on Mac OS X

When Mac Chrome was 32-bit, we needed to disable ASLR for NaCl because
otherwise address space would get fragmented and we wouldn't be able
to allocate enough contiguous address space (issue 90221).

This is no longer necessary now that Mac Chrome is 64-bit (issue
18323).

BUG=90221
BUG=18323
TEST=browser_tests

Committed: https://crrev.com/15082cfc975b356fc9c5e4f1e5a5b758b80a30aa
Cr-Commit-Position: refs/heads/master@{#345704}

[Mark Seaborn, 2015-08-25 20:08:27]

The CQ bit was checked by mseaborn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-25 20:09:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312273002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312273002/1

[commit-bot: I haz the power, 2015-08-25 21:13:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-25 21:13:52]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Mark Seaborn, 2015-08-25 22:14:22]

mseaborn@chromium.org changed reviewers:
+ kerrnel@chromium.org, mark@chromium.org

[Mark Seaborn, 2015-08-25 22:15:54]

I could also remove ChildProcessHost::CHILD_NO_PIE and "Chromium Helper NP", or
do that in a separate change.

[Mark Mentovai, 2015-08-25 22:17:55]

LGTM. I’d like to remove the other vestiges of NO_PIE too. Greg, did you already
have a change for that?

For that matter, the executable-heap helper and surrounding machinery also need
to go.

[Greg K, 2015-08-25 22:19:58]

Yes, I'm working on a CL for that, although it's not yet complete. How
do we want to coordinate this?

On Tue, Aug 25, 2015 at 3:17 PM,  <mark@chromium.org> wrote:
> LGTM. I’d like to remove the other vestiges of NO_PIE too. Greg, did you
> already
> have a change for that?
>
> For that matter, the executable-heap helper and surrounding machinery also
> need
> to go.
>
> https://codereview.chromium.org/1312273002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Mark Mentovai, 2015-08-25 22:20:54]

You can work that out with Mark. I’m happy taking this change right now.

[Greg K, 2015-08-25 22:21:50]

Yeah, if that change is fine on its own, lets just take the change and
I'll land my CL, hopefully in the next week.

On Tue, Aug 25, 2015 at 3:20 PM,  <mark@chromium.org> wrote:
> You can work that out with Mark. I’m happy taking this change right now.
>
> https://codereview.chromium.org/1312273002/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Mark Mentovai, 2015-08-25 22:22:30]

Cool, I guess that takes Mark off the hook for the follow-up to remove the rest
of NP.

[Mark Seaborn, 2015-08-25 22:22:35]

The CQ bit was checked by mseaborn@chromium.org

[commit-bot: I haz the power, 2015-08-25 22:23:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312273002/20001

[commit-bot: I haz the power, 2015-08-25 22:32:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-25 22:32:05]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mark Seaborn, 2015-08-26 05:32:43]

The CQ bit was checked by mseaborn@chromium.org

[commit-bot: I haz the power, 2015-08-26 05:32:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312273002/20001

[commit-bot: I haz the power, 2015-08-26 05:41:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-26 05:41:41]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Mark Seaborn, 2015-08-26 13:35:16]

mseaborn@chromium.org changed reviewers:
+ cpu@chromium.org

[Mark Seaborn, 2015-08-26 13:35:32]

+cpu for OWNERS sign off on chrome/app/chrome_main_delegate.cc

[cpu_(ooo_6.6-7.5), 2015-08-26 20:56:15]

lgtm

[Mark Seaborn, 2015-08-26 21:51:11]

The CQ bit was checked by mseaborn@chromium.org

[commit-bot: I haz the power, 2015-08-26 21:51:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1312273002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1312273002/20001

[commit-bot: I haz the power, 2015-08-26 22:39:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-08-26 22:39:50]

Patchset 2 (id:??) landed as
https://crrev.com/15082cfc975b356fc9c5e4f1e5a5b758b80a30aa
Cr-Commit-Position: refs/heads/master@{#345704}