Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 131223009: Delete useless --loop-weight flag (Closed)

Created:
6 years, 11 months ago by Jakob Kummerow
Modified:
6 years, 11 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Delete useless --loop-weight flag killing a static variable in the process. BUG=chromium:333871 LOG=N R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18587

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M src/flag-definitions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen-instructions.cc View 3 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jakob Kummerow
PTAL.
6 years, 11 months ago (2014-01-14 13:33:40 UTC) #1
ulan
lgtm if it doesn't regress benchmarks.
6 years, 11 months ago (2014-01-14 13:35:33 UTC) #2
Jakob Kummerow
This patch doesn't change behavior, for two reasons: (1) The flag's value was 1 anyway, ...
6 years, 11 months ago (2014-01-14 13:38:44 UTC) #3
Jakob Kummerow
6 years, 11 months ago (2014-01-14 13:45:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r18587 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698