[rac] Format an address for display.

third_party/libaddressinput/chromium/cpp/src/rule.cc

Index: third_party/libaddressinput/chromium/cpp/src/rule.cc
diff --git a/third_party/libaddressinput/chromium/cpp/src/rule.cc b/third_party/libaddressinput/chromium/cpp/src/rule.cc
index 006ea58714e275971a9a6eb282d7cc2bcfe26293..142c9ebe802173387f652c9d6bc69de86cce92f7 100644
--- a/third_party/libaddressinput/chromium/cpp/src/rule.cc
+++ b/third_party/libaddressinput/chromium/cpp/src/rule.cc
@@ -71,27 +71,46 @@ bool ParseToken(char c, AddressField* field) {
 // Clears |fields|, parses |format|, and adds the format address fields to
 // |fields|.
 //
-// For example, the address format in Switzerland is "%O%n%N%n%A%nAX-%Z
-// %C%nÅLAND". It includes the allowed fields prefixed with %, newlines denoted
-// %n, and the extra text that should be included on an envelope. This function
-// parses only the tokens denoted % to determine how an address input form
-// should be laid out.
-//
-// The format string "%O%n%N%n%A%nAX-%Z%C%nÅLAND" is parsed into
-// {{ORGANIZATION}, {RECIPIENT}, {STREET_ADDRESS}, {POSTAL_CODE, LOCALITY}, {}}.
-void ParseAddressFieldsFormat(const std::string& format,
-                              std::vector<std::vector<AddressField> >* fields) {
-  assert(fields != NULL);
-  fields->clear();
-  fields->resize(1);
-  std::vector<std::string> format_parts;
-  SplitString(format, '%', &format_parts);
-  for (size_t i = 1; i < format_parts.size(); ++i) {
+// For example, the address format in Finland is "%O%n%N%n%A%nAX-%Z %C%nÅLAND".
+// It includes the allowed fields prefixed with %, newlines denoted %n, and the
+// extra text that should be included on an envelope. It is parsed into:
+// {
+//     {ORGANIZATION},
+//     {RECIPIENT},
+//     {STREET_ADDRESS},
+//     {"AX-", POSTAL_CODE, " ", LOCALITY},
+//     {"ÅLAND"}
+// }
+void ParseAddressFieldsFormat(
+    const std::string& data,
+    std::vector<std::vector<FormatElement> >* elements) {

[Evan Stade, 2014/01/14 23:45:36]

nit: s/elements/lines

[please use gerrit instead, 2014/01/15 00:05:47]

Done.

+  assert(elements != NULL);
+  elements->clear();
+  elements->resize(1);
+
+  std::vector<std::string> data_parts;
+  SplitString(data, '%', &data_parts);
+
+  // If the address format starts with a literal, then it will be in the first
+  // element of |data_parts|. This literal does not begin with % and should not
+  // be parsed as a token.
+  if (!data_parts.empty() && !data_parts[0].empty()) {
+    elements->back().push_back(FormatElement(data_parts[0]));
+  }
+
+

[Evan Stade, 2014/01/14 23:45:36]

^H

[please use gerrit instead, 2014/01/15 00:05:47]

Done.

+  // The rest of the elements in |data_parts| begin with %. The first character
+  // after % denotes a field or a newline token. The rest of the string after
+  // the token is a literal.

[Evan Stade, 2014/01/14 23:45:36]

thanks for the explanation. To make the code more self-documenting, you could
use some local variables:

const char control_character = data_parts[i][0];
std::string literal = data_parts[i].substr(1);

[please use gerrit instead, 2014/01/15 00:05:47]

Done.

+  for (size_t i = 1; i < data_parts.size(); ++i) {
     AddressField field = COUNTRY;
-    if (ParseToken(format_parts[i][0], &field)) {
-      fields->back().push_back(field);
-    } else if (format_parts[i][0] == 'n') {
-      fields->push_back(std::vector<AddressField>());
+    if (ParseToken(data_parts[i][0], &field)) {
+      elements->back().push_back(FormatElement(field));
+    } else if (data_parts[i][0] == 'n') {
+      elements->push_back(std::vector<FormatElement>());
+    }
+    if (data_parts[i].length() > 1) {
+      elements->back().push_back(FormatElement(data_parts[i].substr(1)));
     }
   }
 }
@@ -173,6 +192,20 @@ int GetPostalCodeMessageId(const std::string& postal_code_type, bool error) {
 
 }  // namespace
 
+FormatElement::FormatElement(AddressField field)
+    : field(field), literal() {}
+
+FormatElement::FormatElement(const std::string& literal)
+    : field(COUNTRY), literal(literal) {
+  assert(!literal.empty());
+}
+
+FormatElement::~FormatElement() {}
+
+bool FormatElement::operator==(const FormatElement& other) const {
+  return field == other.field && literal == other.literal;
+}
+
 Rule::Rule()
     : format_(),
       required_(),