content/browser/frame_host/navigator_impl.cc - Issue 1312213010: PageLoadMetrics renderer and browser implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 1312213010: PageLoadMetrics renderer and browser implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Instrumented NavigationHandle for IsSamePage, fixed broken logic and tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/navigation_handle_impl.cc ('K') | « content/browser/frame_host/navigation_handle_impl.cc ('k') | content/public/browser/navigation_handle.h » ('j') | content/public/browser/navigation_handle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index b2be362dfb61d9b6904098078d4c62f5f2c1cbc6..206a558827bb30a98348430af08bd1b5f66eca70 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -410,6 +410,8 @@ void NavigatorImpl::DidNavigate(

// Run tasks that must execute just before the commit.

bool is_navigation_within_page = controller_->IsURLInPageNavigation(

params.url, params.was_within_same_page, render_frame_host);

+ render_frame_host->navigation_handle()->set_is_same_page(

clamy 2015/09/08 13:25:59 As mentioned in the NavigationHandleImpl, instead

Charlie Harrison 2015/09/08 23:05:16 Done.

+ is_navigation_within_page);

delegate_->DidNavigateMainFramePreCommit(is_navigation_within_page);

}