components/page_load_metrics/common/BUILD.gn - Issue 1312213010: PageLoadMetrics renderer and browser implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/common/BUILD.gn

Issue 1312213010: PageLoadMetrics renderer and browser implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Instrumented NavigationHandle for IsSamePage, fixed broken logic and tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/page_load_metrics/browser/page_load_metrics_web_contents_observer_unittest.cc ('K') | « components/page_load_metrics/browser/page_load_metrics_web_contents_observer_unittest.cc ('k') | components/page_load_metrics/common/page_load_metrics_messages.h » ('j') | components/page_load_metrics/common/page_load_timing.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/common/BUILD.gn

diff --git a/components/data_reduction_proxy/content/common/BUILD.gn b/components/page_load_metrics/common/BUILD.gn

similarity index 52%

copy from components/data_reduction_proxy/content/common/BUILD.gn

copy to components/page_load_metrics/common/BUILD.gn

index cb33fbee498d4127521eb631ae39c2e1a9b92d07..8ba2aad4599b5c77c6530deb8677c1274429f618 100644

--- a/components/data_reduction_proxy/content/common/BUILD.gn

+++ b/components/page_load_metrics/common/BUILD.gn

@@ -2,15 +2,16 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

+# GYP version: components/page_load_metrics.gypi:page_load_metrics_common

static_library("common") {

sources = [

- "data_reduction_proxy_messages.cc",

- "data_reduction_proxy_messages.h",

+ "page_load_metrics_messages.cc",

+ "page_load_metrics_messages.h",

+ "page_load_timing.cc",

+ "page_load_timing.h",

]

deps = [

- "//content/public/common",

+ "//base",

"//ipc",

- "//net",

]

}