chrome/browser/ui/tab_helpers.cc - Issue 1312213010: PageLoadMetrics renderer and browser implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_helpers.cc

Issue 1312213010: PageLoadMetrics renderer and browser implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Instrumented NavigationHandle for IsSamePage, fixed broken logic and tests Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/DEPS ('k') | chrome/chrome_browser_ui.gypi » ('j') | components/page_load_metrics/browser/page_load_metrics_web_contents_observer.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/tab_helpers.cc

diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc

index 5f477c0dc193476a09ec612b226bb6f4a0527569..f6ead7e9b7e6d4671ed5d216781fb08825e031a4 100644

--- a/chrome/browser/ui/tab_helpers.cc

+++ b/chrome/browser/ui/tab_helpers.cc

@@ -44,6 +44,7 @@

#include "components/dom_distiller/core/dom_distiller_switches.h"

#include "components/history/content/browser/web_contents_top_sites_observer.h"

#include "components/history/core/browser/top_sites.h"

+#include "components/page_load_metrics/browser/page_load_metrics_web_contents_observer.h"

#include "components/password_manager/core/browser/password_manager.h"

#include "components/tracing/tracing_switches.h"

#include "content/public/browser/web_contents.h"

@@ -163,6 +164,8 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {

ManagePasswordsUIController::CreateForWebContents(web_contents);

NavigationCorrectionTabObserver::CreateForWebContents(web_contents);

NavigationMetricsRecorder::CreateForWebContents(web_contents);

+ page_load_metrics::WebContentsObserver::CreateForWebContents(

+ web_contents);

PopupBlockerTabHelper::CreateForWebContents(web_contents);

PrefsTabHelper::CreateForWebContents(web_contents);

prerender::PrerenderTabHelper::CreateForWebContents(web_contents);

« no previous file with comments | « chrome/browser/ui/DEPS ('k') | chrome/chrome_browser_ui.gypi » ('j') | components/page_load_metrics/browser/page_load_metrics_web_contents_observer.h » ('J')