Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 1312213010: PageLoadMetrics renderer and browser implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Relax DCHECK constraints slightly for tests Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator_impl.cc
diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc
index 53417fc3adacec03cb632be18610979ae65f0956..b03e23232008f6d935da400a57fa968a2fc1965c 100644
--- a/content/browser/frame_host/navigator_impl.cc
+++ b/content/browser/frame_host/navigator_impl.cc
@@ -390,6 +390,8 @@ void NavigatorImpl::DidNavigate(
FrameTree* frame_tree = render_frame_host->frame_tree_node()->frame_tree();
bool oopifs_possible = SiteIsolationPolicy::AreCrossProcessFramesPossible();
+ bool is_navigation_within_page = controller_->IsURLInPageNavigation(
+ params.url, params.was_within_same_page, render_frame_host);
if (ui::PageTransitionIsMainFrame(params.transition)) {
if (delegate_) {
// When overscroll navigation gesture is enabled, a screenshot of the page
@@ -408,8 +410,6 @@ void NavigatorImpl::DidNavigate(
}
// Run tasks that must execute just before the commit.
- bool is_navigation_within_page = controller_->IsURLInPageNavigation(
- params.url, params.was_within_same_page, render_frame_host);
delegate_->DidNavigateMainFramePreCommit(is_navigation_within_page);
}
@@ -485,7 +485,8 @@ void NavigatorImpl::DidNavigate(
delegate_->DidCommitProvisionalLoad(render_frame_host,
params.url,
transition_type);
- render_frame_host->navigation_handle()->DidCommitNavigation();
+ render_frame_host->navigation_handle()->DidCommitNavigation(
+ is_navigation_within_page);
}
if (!did_navigate)

Powered by Google App Engine
This is Rietveld 408576698