Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: components/page_load_metrics/renderer/metrics_render_frame_observer.cc

Issue 1312213010: PageLoadMetrics renderer and browser implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed top-level UMA name to PageLoad Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/renderer/metrics_render_frame_observer.cc
diff --git a/components/page_load_metrics/renderer/metrics_render_frame_observer.cc b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc
new file mode 100644
index 0000000000000000000000000000000000000000..7fe0979cc5d40975ce77a132ca284eba29662b9c
--- /dev/null
+++ b/components/page_load_metrics/renderer/metrics_render_frame_observer.cc
@@ -0,0 +1,105 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/page_load_metrics/renderer/metrics_render_frame_observer.h"
+
+#include "base/time/time.h"
+#include "base/timer/timer.h"
+#include "components/page_load_metrics/renderer/page_timing_metrics_sender.h"
+#include "content/public/renderer/render_frame.h"
+#include "third_party/WebKit/public/platform/WebURLResponse.h"
+#include "third_party/WebKit/public/web/WebDataSource.h"
+#include "third_party/WebKit/public/web/WebDocument.h"
+#include "third_party/WebKit/public/web/WebLocalFrame.h"
+#include "third_party/WebKit/public/web/WebPerformance.h"
+#include "url/gurl.h"
+
+namespace page_load_metrics {
+
+MetricsRenderFrameObserver::MetricsRenderFrameObserver(
+ content::RenderFrame* render_frame)
+ : content::RenderFrameObserver(render_frame) {}
+
+MetricsRenderFrameObserver::~MetricsRenderFrameObserver() {}
+
+void MetricsRenderFrameObserver::DidChangePerformanceTiming() {
+ SendMetrics();
+}
+
+void MetricsRenderFrameObserver::DidCommitProvisionalLoad(
+ bool is_new_navigation,
+ bool is_same_page_navigation) {
+ // Same-page navigations (e.g. an in-document navigation from a fragment
+ // link) aren't full page loads, since they don't go to network to load the
+ // main HTML resource. DidStartProvisionalLoad doesn't get invoked for same
+ // page navigations, so we may still have an active
+ // page_timing_metrics_sender_ at this point.
+ if (is_same_page_navigation)
+ return;
+
+ // Make sure to release the sender for a previous navigation, if we have one.
+ page_timing_metrics_sender_.reset();
+
+ // We only create a PageTimingMetricsSender if the page meets the criteria for
+ // sending and recording metrics. Once page_timing_metrics_sender_ is
+ // non-null, we will send metrics for the current page at some later time, as
+ // those metrics become available.
+ if (ShouldSendMetrics()) {
+ page_timing_metrics_sender_.reset(
+ new PageTimingMetricsSender(this, routing_id(), CreateTimer()));
+ }
+}
+
+void MetricsRenderFrameObserver::SendMetrics() {
+ if (!page_timing_metrics_sender_)
+ return;
+
+ PageLoadTiming timing(GetTiming());
+ page_timing_metrics_sender_->Send(timing);
+}
+
+bool MetricsRenderFrameObserver::ShouldSendMetrics() const {
+ const blink::WebLocalFrame& frame = *render_frame()->GetWebFrame();
nasko 2015/09/14 23:32:25 Why use a reference and not the pointer itself? I
Charlie Harrison 2015/09/16 22:37:38 Done.
+ // We only generate historgrams for main frames.
+ if (frame.parent())
+ return false;
+
+ const blink::WebDocument& document = frame.document();
+ // Ignore non-HTTP schemes (e.g. chrome://).
+ const GURL& url = document.url();
+ if (!url.SchemeIsHTTPOrHTTPS())
+ return false;
+
+ const blink::WebURLResponse& url_response = frame.dataSource()->response();
+ // Ignore multipart responses (e.g. MHTML).
+ if (url_response.isMultipartPayload())
+ return false;
+
+ // Ignore non-HTML documents (e.g. SVG). Note that images are treated by
+ // Blink as HTML documents, so to exclude images, we must perform
+ // additional mime type checking below.
+ if (!document.isHTMLDocument() && !document.isXHTMLDocument())
+ return false;
+
+ // Ignore non-HTML mime types (e.g. images).
+ std::string mime_type = url_response.mimeType().utf8();
+ if (mime_type != "text/html" && mime_type != "application/xhtml+xml")
+ return false;
+
+ return true;
+}
+
+PageLoadTiming MetricsRenderFrameObserver::GetTiming() const {
+ blink::WebLocalFrame* frame = render_frame()->GetWebFrame();
+ if (frame)
nasko 2015/09/14 23:32:25 I don't think this check is needed, as RenderFrame
Charlie Harrison 2015/09/16 22:37:38 Done.
+ return PageLoadTiming(frame->performance());
+ return PageLoadTiming();
+}
+
+scoped_ptr<base::Timer> MetricsRenderFrameObserver::CreateTimer() const {
+ return scoped_ptr<base::Timer>(
+ new base::OneShotTimer<PageTimingMetricsSender>());
+}
+
+} // namespace page_load_metrics

Powered by Google App Engine
This is Rietveld 408576698