content/public/browser/navigation_handle.h - Issue 1312213010: PageLoadMetrics renderer and browser implementation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/navigation_handle.h

Issue 1312213010: PageLoadMetrics renderer and browser implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added gmock dependency to browser/ Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/page_load_metrics/common/page_load_timing.cc ('K') | « content/content_tests.gypi ('k') | content/public/test/mock_navigation_handle.h » ('j') | content/public/test/mock_navigation_handle.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/browser/navigation_handle.h

diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h

index 49d0884de43256e204ad3159903db42e889d1af6..ef35294ca85d4c4a309d57616fb73e9a804b16af 100644

--- a/content/public/browser/navigation_handle.h

+++ b/content/public/browser/navigation_handle.h

@@ -28,6 +28,10 @@ class CONTENT_EXPORT NavigationHandle {

// Whether the navigation is taking place in the main frame or in a subframe.

virtual bool IsInMainFrame() const = 0;

+ // Whether the navigation happened in the same page. This is only known

+ // after the navigation has committed.

Bryan McQuade 2015/09/10 00:45:58 let's extend this comment with "It is an error to

+ virtual bool IsSamePage() const = 0;

// Whether the navigation has successfully committed a document.

virtual bool HasCommittedDocument() const = 0;