PageLoadMetrics renderer and browser implementation.

components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

Index: components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc
diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc b/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..8ae2ef83f82264da69aa8330ab4b2a033e2d842d
--- /dev/null
+++ b/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc
@@ -0,0 +1,186 @@
+// Copyright (c) 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/page_load_metrics/browser/metrics_web_contents_observer.h"
+
+#include "base/memory/scoped_ptr.h"
+#include "base/process/kill.h"
+#include "base/test/histogram_tester.h"
+#include "base/time/time.h"
+#include "components/page_load_metrics/common/page_load_metrics_messages.h"
+#include "content/public/browser/navigation_handle.h"
+#include "content/public/test/mock_navigation_handle.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "testing/gmock/include/gmock/gmock.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using testing::Return;
+using testing::ReturnRef;
+using testing::NiceMock;
+
+namespace content {
+
+class RenderFrameHost;
+
+}  //  namespace content
+
+namespace page_load_metrics {
+
+namespace {
+
+const char kDefaultTestUrl[] = "https://google.com";
+
+void SetNavigationHandleExpectations(content::MockNavigationHandle* handle) {
+  ON_CALL(*handle, IsInMainFrame()).WillByDefault(Return(true));
+  ON_CALL(*handle, IsSamePage()).WillByDefault(Return(false));
+  ON_CALL(*handle, HasCommittedDocument()).WillByDefault(Return(true));
+}
+
+}  //  namespace
+
+class MockMetricsWebContentsObserver : public MetricsWebContentsObserver {
+ public:
+  MockMetricsWebContentsObserver()
+      : MetricsWebContentsObserver(nullptr), url_(kDefaultTestUrl) {
+    ON_CALL(*this, GetLastCommittedURL()).WillByDefault(ReturnRef(url_));
+    ON_CALL(*this, IsCurrentMainFrame(testing::_)).WillByDefault(Return(true));
+  }
+  MOCK_METHOD0(GetLastCommittedURL, const GURL&());
+  MOCK_METHOD1(IsCurrentMainFrame, bool(content::RenderFrameHost*));
+
+ private:
+  GURL url_;

[Bryan McQuade, 2015/09/10 00:45:58]

since you set this in the initializer list, you should be able to mark it as
const:
const GURL url_;

+  content::TestBrowserThreadBundle thread_bundle_;
+};
+
+class MetricsWebContentsObserverTest : public testing::Test {
+ public:
+  const char* kHistogramNameFirstLayout = "PageLoad.Timing.FirstLayout";
+  const char* kHistogramNameDomContent =
+      "PageLoad.Timing.DOMContentLoadedEventFired";
+  const char* kHistogramNameLoad = "PageLoad.Timing.LoadEventFired";
+
+  MetricsWebContentsObserverTest()
+      : observer_(), mock_nav_handle_(GURL(kDefaultTestUrl)) {}
+
+  void SetUp() override { SetNavigationHandleExpectations(&mock_nav_handle_); }
+
+  void AssertNoHistogramsLogged() {
+    histogram_tester_.ExpectTotalCount(kHistogramNameDomContent, 0);
+    histogram_tester_.ExpectTotalCount(kHistogramNameLoad, 0);
+    histogram_tester_.ExpectTotalCount(kHistogramNameFirstLayout, 0);
+  }
+
+ protected:
+  base::HistogramTester histogram_tester_;
+  NiceMock<MockMetricsWebContentsObserver> observer_;
+  NiceMock<content::MockNavigationHandle> mock_nav_handle_;
+};
+
+TEST_F(MetricsWebContentsObserverTest, NoMetrics) {
+  AssertNoHistogramsLogged();
+}
+
+TEST_F(MetricsWebContentsObserverTest, NotInMainFrame) {
+  base::TimeDelta first_layout = base::TimeDelta::FromMilliseconds(1);
+
+  PageLoadTiming timing;
+  timing.navigation_start = base::Time::FromDoubleT(1);
+  timing.first_layout = first_layout;
+  EXPECT_CALL(mock_nav_handle_, IsInMainFrame()).WillRepeatedly(Return(false));
+
+  observer_.DidCommitNavigation(&mock_nav_handle_);
+  observer_.OnMessageReceived(
+      PageLoadMetricsMsg_TimingUpdated(observer_.routing_id(), timing),
+      nullptr);
+  // Navigate again to force histogram recording.
+  observer_.DidCommitNavigation(&mock_nav_handle_);
+  AssertNoHistogramsLogged();
+}
+
+TEST_F(MetricsWebContentsObserverTest, SamePage) {
+  base::TimeDelta first_layout = base::TimeDelta::FromMilliseconds(1);
+
+  PageLoadTiming timing;
+  timing.navigation_start = base::Time::FromDoubleT(1);
+  timing.first_layout = first_layout;
+  EXPECT_CALL(mock_nav_handle_, IsSamePage()).WillRepeatedly(Return(true));
+
+  observer_.DidCommitNavigation(&mock_nav_handle_);
+  observer_.OnMessageReceived(
+      PageLoadMetricsMsg_TimingUpdated(observer_.routing_id(), timing),
+      nullptr);
+  // Navigate again to force histogram recording.
+  observer_.DidCommitNavigation(&mock_nav_handle_);
+  AssertNoHistogramsLogged();
+}
+
+TEST_F(MetricsWebContentsObserverTest, SingleMetricAfterCommit) {
+  base::TimeDelta first_layout = base::TimeDelta::FromMilliseconds(1);
+
+  PageLoadTiming timing;
+  timing.navigation_start = base::Time::FromDoubleT(1);
+  timing.first_layout = first_layout;
+  observer_.DidCommitNavigation(&mock_nav_handle_);
+  observer_.OnMessageReceived(
+      PageLoadMetricsMsg_TimingUpdated(observer_.routing_id(), timing),
+      nullptr);
+
+  AssertNoHistogramsLogged();
+
+  // Navigate again to force histogram recording.
+  observer_.DidCommitNavigation(&mock_nav_handle_);
+
+  histogram_tester_.ExpectTotalCount(kHistogramNameDomContent, 0);
+  histogram_tester_.ExpectTotalCount(kHistogramNameLoad, 0);
+  histogram_tester_.ExpectTotalCount(kHistogramNameFirstLayout, 1);
+  histogram_tester_.ExpectBucketCount(kHistogramNameFirstLayout,
+                                      first_layout.InMilliseconds(), 1);
+}
+
+TEST_F(MetricsWebContentsObserverTest, MultipleMetricsAfterCommits) {
+  base::TimeDelta first_layout_1 = base::TimeDelta::FromMilliseconds(1);
+  base::TimeDelta first_layout_2 = base::TimeDelta::FromMilliseconds(20);
+  base::TimeDelta response = base::TimeDelta::FromMilliseconds(10);
+  base::TimeDelta dom_content = base::TimeDelta::FromMilliseconds(40);
+  base::TimeDelta load = base::TimeDelta::FromMilliseconds(100);
+
+  PageLoadTiming timing;
+  timing.navigation_start = base::Time::FromDoubleT(1);
+  timing.first_layout = first_layout_1;
+  timing.response_start = response;
+  timing.dom_content_loaded_event_start = dom_content;
+  timing.load_event_start = load;
+  observer_.DidCommitNavigation(&mock_nav_handle_);
+  observer_.OnMessageReceived(
+      PageLoadMetricsMsg_TimingUpdated(observer_.routing_id(), timing),
+      nullptr);
+
+  observer_.DidCommitNavigation(&mock_nav_handle_);
+  PageLoadTiming timing2;
+  timing2.navigation_start = base::Time::FromDoubleT(200);
+  timing2.first_layout = first_layout_2;
+  observer_.OnMessageReceived(
+      PageLoadMetricsMsg_TimingUpdated(observer_.routing_id(), timing2),
+      nullptr);
+  observer_.DidCommitNavigation(&mock_nav_handle_);
+
+  histogram_tester_.ExpectBucketCount(kHistogramNameFirstLayout,
+                                      first_layout_1.InMilliseconds(), 1);
+  histogram_tester_.ExpectTotalCount(kHistogramNameFirstLayout, 2);
+  histogram_tester_.ExpectBucketCount(kHistogramNameFirstLayout,
+                                      first_layout_1.InMilliseconds(), 1);
+  histogram_tester_.ExpectBucketCount(kHistogramNameFirstLayout,
+                                      first_layout_2.InMilliseconds(), 1);
+
+  histogram_tester_.ExpectTotalCount(kHistogramNameDomContent, 1);
+  histogram_tester_.ExpectBucketCount(kHistogramNameDomContent,
+                                      dom_content.InMilliseconds(), 1);
+
+  histogram_tester_.ExpectTotalCount(kHistogramNameLoad, 1);
+  histogram_tester_.ExpectBucketCount(kHistogramNameLoad, load.InMilliseconds(),
+                                      1);
+}
+
+}  // namespace page_load_metrics