PageLoadMetrics renderer and browser implementation.

components/page_load_metrics/browser/page_load_metrics_web_contents_observer.h

Index: components/page_load_metrics/browser/page_load_metrics_web_contents_observer.h
diff --git a/components/page_load_metrics/browser/page_load_metrics_web_contents_observer.h b/components/page_load_metrics/browser/page_load_metrics_web_contents_observer.h
new file mode 100644
index 0000000000000000000000000000000000000000..34c2fda499442b961230d4072ef6060903bd1737
--- /dev/null
+++ b/components/page_load_metrics/browser/page_load_metrics_web_contents_observer.h
@@ -0,0 +1,72 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_WEB_CONTENTS_OBSERVER_H_
+#define COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_WEB_CONTENTS_OBSERVER_H_
+
+#include "base/macros.h"
+#include "base/time/time.h"
+#include "components/page_load_metrics/common/page_load_timing.h"
+#include "content/public/browser/web_contents.h"
+#include "content/public/browser/web_contents_observer.h"
+#include "content/public/browser/web_contents_user_data.h"
+
+namespace content {
+class NavigationHandle;
+class RenderFrameHost;
+}  // namespace content
+
+namespace IPC {
+class Message;
+}  // namespace IPC
+
+namespace page_load_metrics {
+
+struct PageLoadTiming;
+
+// MetricsWebContentsObserver logs page load UMA metrics based on
+// IPC messages received from a MainRenderFrameObserver.
+class MetricsWebContentsObserver
+    : public content::WebContentsObserver,
+      public content::WebContentsUserData<MetricsWebContentsObserver> {
+ public:
+  ~MetricsWebContentsObserver() override;
+
+  // MetricsWebContentsObserver implementation
+  bool OnMessageReceived(const IPC::Message& message,
+                         content::RenderFrameHost* render_frame_host) override;
+  void DidCommitNavigation(
+      content::NavigationHandle* navigation_handle) override;
+  void RenderProcessGone(base::TerminationStatus status) override;
+
+ protected:
+  bool HandleMessageReceived(const IPC::Message& message,

[Bryan McQuade, 2015/09/09 16:26:25]

given the discovery around the test thread bundle, seems this can be made
private (or even folded back into OnMessageReceived - up to you)

[Charlie Harrison, 2015/09/09 17:32:03]

Done, folded it into OnMessageReceived.

+                             content::RenderFrameHost* render_frame_host);
+
+ private:
+  explicit MetricsWebContentsObserver(content::WebContents* web_contents);
+  friend class content::WebContentsUserData<MetricsWebContentsObserver>;
+  friend class MetricsWebContentsObserverTest;
+  friend class MockMetricsWebContentsObserver;
+
+  void OnTimingUpdated(content::RenderFrameHost*, const PageLoadTiming& timing);
+  void RecordTimingHistograms();
+
+  bool IsRelevantNavigation(content::NavigationHandle* navigation_handle);
+  // Used for testing, so we don't have to mock a whole WebContents

[Bryan McQuade, 2015/09/09 16:26:25]

suggest adding a newline before this comment

[Charlie Harrison, 2015/09/09 17:32:03]

Done.

+  virtual const GURL& GetLastCommittedURL();
+  virtual bool IsCurrentMainFrame(content::RenderFrameHost*);
+
+  content::RenderFrameHost* current_host_;
+
+  // Will be null before any navigations have committed. When a navigation
+  // commits we will initialize this as empty.
+  scoped_ptr<PageLoadTiming> current_timing_;
+
+  DISALLOW_COPY_AND_ASSIGN(MetricsWebContentsObserver);
+};
+
+}  // namespace page_load_metrics
+
+#endif  // COMPONENTS_PAGE_LOAD_METRICS_BROWSER_PAGE_LOAD_METRICS_WEB_CONTENTS_OBSERVER_H_