Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Side by Side Diff: components/page_load_metrics/browser/metrics_web_contents_observer.cc

Issue 1312213010: PageLoadMetrics renderer and browser implementation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Prevent data loss on sender destruction Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "components/page_load_metrics/browser/metrics_web_contents_observer.h"
6
7 #include "base/logging.h"
8 #include "base/metrics/histogram.h"
9 #include "components/page_load_metrics/common/page_load_metrics_messages.h"
10 #include "components/page_load_metrics/common/page_load_timing.h"
11 #include "content/public/browser/browser_thread.h"
12 #include "content/public/browser/navigation_details.h"
13 #include "content/public/browser/navigation_handle.h"
14 #include "content/public/browser/render_frame_host.h"
15 #include "content/public/browser/web_contents.h"
16 #include "content/public/browser/web_contents_observer.h"
17 #include "content/public/browser/web_contents_user_data.h"
18 #include "ipc/ipc_message.h"
19 #include "ipc/ipc_message_macros.h"
20
21 DEFINE_WEB_CONTENTS_USER_DATA_KEY(
22 page_load_metrics::MetricsWebContentsObserver);
23
24 namespace page_load_metrics {
25
26 namespace {
27
28 bool IsValidPageLoadTiming(const PageLoadTiming& timing) {
29 if (timing.IsEmpty())
30 return false;
31
32 // If we have a non-empty timing, it should always have a navigation start.
33 if (timing.navigation_start.is_null())
34 return false;
35
36 // If we have a dom content loaded event, we should have a response start.
37 if (!timing.dom_content_loaded_event_start.is_zero()) {
38 if (timing.response_start.is_zero() ||
39 timing.dom_content_loaded_event_start < timing.response_start) {
40 return false;
41 }
42 }
43
44 // If we have a load event, we should have both a response start and a DCL.
45 if (!timing.load_event_start.is_zero()) {
46 if (timing.response_start.is_zero() ||
47 timing.dom_content_loaded_event_start.is_zero() ||
48 timing.load_event_start < timing.dom_content_loaded_event_start ||
49 timing.load_event_start < timing.response_start) {
50 return false;
51 }
52 }
53
54 return true;
55 }
56
57 } // namespace
Alexei Svitkine (slow) 2015/09/11 21:26:48 Nit: Add an empty line below.
58 MetricsWebContentsObserver::MetricsWebContentsObserver(
59 content::WebContents* web_contents)
60 : content::WebContentsObserver(web_contents), current_host_(nullptr) {}
61
62 // As a tab helper, this object is tied to a single WebContent
63 // for its entire lifetime.
64 MetricsWebContentsObserver::~MetricsWebContentsObserver() {
65 RecordTimingHistograms();
66 }
67
68 void MetricsWebContentsObserver::FrameDeleted(
69 content::RenderFrameHost* render_frame_host) {
70 if (render_frame_host == current_host_)
71 current_host_ = nullptr;
72 }
73
74 bool MetricsWebContentsObserver::OnMessageReceived(
75 const IPC::Message& message,
76 content::RenderFrameHost* render_frame_host) {
77 DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
78 bool handled = true;
79 IPC_BEGIN_MESSAGE_MAP_WITH_PARAM(MetricsWebContentsObserver, message,
80 render_frame_host)
81 IPC_MESSAGE_HANDLER(PageLoadMetricsMsg_TimingUpdated, OnTimingUpdated)
82 IPC_MESSAGE_UNHANDLED(handled = false)
83 IPC_END_MESSAGE_MAP()
84 return handled;
85 }
86
87 void MetricsWebContentsObserver::DidCommitNavigation(
88 content::NavigationHandle* navigation_handle) {
89 if (navigation_handle->IsInMainFrame() && !navigation_handle->IsSamePage())
90 RecordTimingHistograms();
91 if (IsRelevantNavigation(navigation_handle)) {
92 current_timing_.reset(new PageLoadTiming());
93 }
94 }
95
96 // This will occur when the process for the main RenderFrameHost exits.
97 // This will happen with a normal exit or a crash.
98 void MetricsWebContentsObserver::RenderProcessGone(
99 base::TerminationStatus status) {
100 RecordTimingHistograms();
101 }
102
103 #define PAGE_LOAD_HISTOGRAM(name, sample) \
104 UMA_HISTOGRAM_CUSTOM_TIMES(name, sample, \
105 base::TimeDelta::FromMilliseconds(10), \
106 base::TimeDelta::FromMinutes(10), 100);
107
108 void MetricsWebContentsObserver::OnTimingUpdated(
109 content::RenderFrameHost* render_frame_host,
110 const PageLoadTiming& timing) {
111 if (!current_timing_)
112 return;
113
114 // We may receive notifications from frames that have been navigated away
115 // from. We simply ignore them.
116 if (render_frame_host != web_contents()->GetMainFrame())
117 return;
118
119 // See comment in IsRelevantNavigation about
120 // browser/renderer url disagreement (newtab).
121 if (!web_contents()->GetLastCommittedURL().SchemeIsHTTPOrHTTPS())
122 return;
123
124 // Throw away IPCs that are not relevant to the current navigation.
125 if (!current_timing_->navigation_start.is_null() &&
126 timing.navigation_start != current_timing_->navigation_start) {
127 // TODO(csharrison) uma log a counter here
128 return;
129 }
130
131 if (current_timing_->IsEmpty())
132 current_host_ = render_frame_host;
133 else
134 DCHECK_EQ(render_frame_host, current_host_);
135 *current_timing_ = timing;
136 }
137
138 void MetricsWebContentsObserver::RecordTimingHistograms() {
139 if (!current_timing_ || !IsValidPageLoadTiming(*current_timing_))
140 return;
141
142 if (!current_timing_->dom_content_loaded_event_start.is_zero()) {
143 PAGE_LOAD_HISTOGRAM(
144 "PageLoadTiming.Navigation.To.DOMContentLoadedEventFired",
145 current_timing_->dom_content_loaded_event_start);
146 }
147
148 if (!current_timing_->load_event_start.is_zero()) {
149 PAGE_LOAD_HISTOGRAM("PageLoadTiming.Navigation.To.LoadEventFired",
150 current_timing_->load_event_start);
151 }
152
153 if (!current_timing_->first_layout.is_zero()) {
154 PAGE_LOAD_HISTOGRAM("PageLoadTiming.Navigation.To.FirstLayout",
155 current_timing_->first_layout);
156 }
157 current_timing_.reset();
158 }
159
160 bool MetricsWebContentsObserver::IsRelevantNavigation(
161 content::NavigationHandle* navigation_handle) {
162 // The url we see from the renderer side is not always the same as what
163 // we see from the browser side (e.g. chrome://newtab). We want to be
164 // sure here that we aren't logging UMA for internal pages.
165 const GURL& browser_url = web_contents()->GetLastCommittedURL();
166 return navigation_handle->IsInMainFrame() &&
167 !navigation_handle->IsSamePage() &&
168 navigation_handle->HasCommittedDocument() &&
169 navigation_handle->GetURL().SchemeIsHTTPOrHTTPS() &&
170 browser_url.SchemeIsHTTPOrHTTPS();
171 }
172
173 } // namespace page_load_metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698