Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 1312213008: Move member function rootEditableElement() out from VisiblePosition class (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move member function rootEditableElement() out from VisiblePosition class This patch moves member function |rootEditableElement()| out from |VisiblePosition| class as global funciton |rootEditableElementOf()| to simplify |VisiblePosition| for introducing composed tree version of |VisiblePosition|. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201479

Patch Set 1 : 2015-08-31T17:23:29 #

Patch Set 2 : 2015-08-31T17:55:42 Include VisiblePosition.h #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M Source/core/editing/DragCaretController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/DragCaretController.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/editing/EditingUtilities.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/EditingUtilities.cpp View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/editing/VisiblePosition.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/editing/commands/InsertListCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-08-31 08:46:36 UTC) #2
yoichio
Your patch missed VisiblePosition.h
5 years, 3 months ago (2015-08-31 08:50:33 UTC) #3
yosin_UTC9
PTAL
5 years, 3 months ago (2015-08-31 08:56:20 UTC) #4
hajimehoshi
lgtm
5 years, 3 months ago (2015-08-31 08:58:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312213008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312213008/20001
5 years, 3 months ago (2015-08-31 08:58:55 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 10:53:23 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201479

Powered by Google App Engine
This is Rietveld 408576698