Issue 1312183003: dart_pkg cleanups

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1312183003: dart_pkg cleanups (Closed)

Created:
5 years, 4 months ago by Cutch

Modified:
5 years, 4 months ago

Reviewers:
zra

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

dart_pkg cleanups - Make apps expect a list of pairs (app name, app entry script) - Remove app_name_override now that each app specifies its name. - Update existing dart_pkg rules to follow this. R=zra@google.com Committed: https://chromium.googlesource.com/external/mojo/+/5a3eb543864cdb89e43242a2d5fbbb0a17d7b2f0

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -65 lines)			Patch
M	examples/dart/device_info/BUILD.gn	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	examples/dart/hello_world/hello/BUILD.gn	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	examples/dart/hello_world/world/BUILD.gn	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	examples/dart/netcat/BUILD.gn	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	examples/dart/traced_application/BUILD.gn	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	examples/dart/wget/BUILD.gn	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	mojo/dart/http_load_test/BUILD.gn	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	mojo/dart/observatory_test/BUILD.gn	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	mojo/public/dart/rules.gni	View	5 chunks	+35 lines, -42 lines	0 comments	Download
M	services/dart/dart_apptests/BUILD.gn	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	services/dart/test/echo/BUILD.gn	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	services/dart/test/pingpong/BUILD.gn	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	services/dart/test/pingpong_target/BUILD.gn	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

5 years, 4 months ago (2015-08-25 19:51:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5a3eb543864cdb89e43242a2d5fbbb0a17d7b2f0 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages