Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1312163008: Forward declare SkStrokeRec in SkPathEffect (Closed)

Created:
5 years, 3 months ago by hal.canary
Modified:
5 years, 3 months ago
Reviewers:
*bungeman-skia, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Forward declare SkStrokeRec in SkPathEffect Committed: https://skia.googlesource.com/skia/+/435657fd62960ceffb1c3c63f63e836373560bc5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M bench/DashBench.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkPathEffect.h View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/ClockFaceView.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkDraw.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkPaint.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkScalerContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/Sk1DPathEffect.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/Sk2DPathEffect.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/SkDashPathEffect.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/SkDiscretePathEffect.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/utils/SkDashPath.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/DashPathEffectTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/DrawPathTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M tests/PathTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
hal.canary
PTAL
5 years, 3 months ago (2015-09-08 14:40:46 UTC) #2
reed1
api lgtm
5 years, 3 months ago (2015-09-08 15:25:50 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312163008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312163008/1
5 years, 3 months ago (2015-09-15 19:44:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312163008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312163008/1
5 years, 3 months ago (2015-09-15 19:49:50 UTC) #10
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 3 months ago (2015-09-15 19:49:51 UTC) #11
bungeman-skia
lgtm
5 years, 3 months ago (2015-09-15 19:49:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312163008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312163008/1
5 years, 3 months ago (2015-09-15 19:52:21 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/435657fd62960ceffb1c3c63f63e836373560bc5
5 years, 3 months ago (2015-09-15 19:53:10 UTC) #17
hal.canary
Now that this landed, should SkStrokeRec.h move to src/core?
5 years, 3 months ago (2015-09-16 15:18:35 UTC) #18
bungeman-skia
5 years, 3 months ago (2015-09-16 15:41:22 UTC) #19
Message was sent while issue was closed. 
On 2015/09/16 15:18:35, Hal Canary wrote:
> Now that this landed, should SkStrokeRec.h move to src/core?

At first I was all over this idea, but it seems a bit weird to have a public
method marked as SK_API, but a user can't actually call it or implement it. (I'm
not sure how one gets an SkStrokeRec, maybe you can get a pointer or reference
to one somewhere and just pass it through on a forward declaration?)

Powered by Google App Engine
This is Rietveld 408576698