Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1312163007: Update the alignment of the chrome://apps theme attribution when theme is installed (Closed)

Created:
5 years, 3 months ago by pkotwicz
Modified:
5 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, arv+watch_chromium.org, pedrosimonetti+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@theme_handler_crash
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the alignment of the chrome://apps theme attribution when theme is installed This CL updates the alignment of the theme attribution on any open chrome://apps pages when the user installs a new theme. BUG=523497 TEST=Manual, see bug Committed: https://crrev.com/b1a17c24b420b95b78558fe36701e0dc1fd6e214 Cr-Commit-Position: refs/heads/master@{#347813}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M chrome/browser/resources/ntp4/new_tab.css View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/ntp4/new_tab_theme.css View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 2 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pkotwicz
dbeam@ can you please take a look?
5 years, 3 months ago (2015-09-08 17:47:53 UTC) #3
Dan Beam
lgtm
5 years, 3 months ago (2015-09-08 21:16:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1312163007/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1312163007/20001
5 years, 3 months ago (2015-09-08 21:40:30 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 3 months ago (2015-09-08 22:32:55 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 22:33:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1a17c24b420b95b78558fe36701e0dc1fd6e214
Cr-Commit-Position: refs/heads/master@{#347813}

Powered by Google App Engine
This is Rietveld 408576698