Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: testing/android/native_test/native_test_launcher.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/test/fake_server/android/fake_server_helper_android.cc ('k') | ui/android/window_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/android/native_test/native_test_launcher.cc
diff --git a/testing/android/native_test/native_test_launcher.cc b/testing/android/native_test/native_test_launcher.cc
index 343f1180c6803ff600589777472790f348c87fc2..52b419d02ba05343791a86911d4499328450337a 100644
--- a/testing/android/native_test/native_test_launcher.cc
+++ b/testing/android/native_test/native_test_launcher.cc
@@ -70,12 +70,12 @@ void AndroidLog(int priority, const char* format, ...) {
} // namespace
static void RunTests(JNIEnv* env,
- jobject obj,
- jstring jcommand_line_flags,
- jstring jcommand_line_file_path,
- jstring jstdout_file_path,
+ const JavaParamRef<jobject>& obj,
+ const JavaParamRef<jstring>& jcommand_line_flags,
+ const JavaParamRef<jstring>& jcommand_line_file_path,
+ const JavaParamRef<jstring>& jstdout_file_path,
jboolean jstdout_fifo,
- jobject app_context) {
+ const JavaParamRef<jobject>& app_context) {
// Command line initialized basically, will be fully initialized later.
static const char* const kInitialArgv[] = { "ChromeTestActivity" };
base::CommandLine::Init(arraysize(kInitialArgv), kInitialArgv);
« no previous file with comments | « sync/test/fake_server/android/fake_server_helper_android.cc ('k') | ui/android/window_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698