content/shell/android/shell_manager.cc - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/android/shell_manager.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/shell/android/linker_test_apk/chromium_linker_test_linker_tests.cc ('k') | content/shell/browser/shell_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/android/shell_manager.cc

diff --git a/content/shell/android/shell_manager.cc b/content/shell/android/shell_manager.cc

index b262c883eddaf46d56b87dfd5f79dd9ba1f66e2f..eb9e6368e601c2fffb3eed5ab15430c3f44c1ac7 100644

--- a/content/shell/android/shell_manager.cc

+++ b/content/shell/android/shell_manager.cc

@@ -49,12 +49,16 @@ bool RegisterShellManager(JNIEnv* env) {

return RegisterNativesImpl(env);

}

-static void Init(JNIEnv* env, jclass clazz, jobject obj) {

+static void Init(JNIEnv* env,

+ const JavaParamRef<jclass>& clazz,

+ const JavaParamRef<jobject>& obj) {

g_global_state.Get().j_shell_manager.Reset(

base::android::ScopedJavaLocalRef<jobject>(env, obj));

}

-void LaunchShell(JNIEnv* env, jclass clazz, jstring jurl) {

+void LaunchShell(JNIEnv* env,

+ const JavaParamRef<jclass>& clazz,

+ const JavaParamRef<jstring>& jurl) {

ShellBrowserContext* browserContext =

ShellContentBrowserClient::Get()->browser_context();

GURL url(base::android::ConvertJavaStringToUTF8(env, jurl));