Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/android/content_video_view.cc ('k') | content/browser/android/content_view_render_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/android/content_view_core_impl.cc
diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc
index a1a84e762df42d9d9a215623208d781b26f21494..5997c99d8c450554208775d2cf5f97bdd64dfcf3 100644
--- a/content/browser/android/content_view_core_impl.cc
+++ b/content/browser/android/content_view_core_impl.cc
@@ -1450,11 +1450,11 @@ void ContentViewCoreImpl::PullReset() {
// This is called for each ContentView.
jlong Init(JNIEnv* env,
- jobject obj,
- jobject web_contents,
- jobject view_android_delegate,
+ const JavaParamRef<jobject>& obj,
+ const JavaParamRef<jobject>& web_contents,
+ const JavaParamRef<jobject>& view_android_delegate,
jlong window_android,
- jobject retained_objects_set) {
+ const JavaParamRef<jobject>& retained_objects_set) {
ContentViewCoreImpl* view = new ContentViewCoreImpl(
env, obj, WebContents::FromJavaWebContents(web_contents),
view_android_delegate,
@@ -1463,8 +1463,10 @@ jlong Init(JNIEnv* env,
return reinterpret_cast<intptr_t>(view);
}
-static ScopedJavaLocalRef<jobject>
-FromWebContentsAndroid(JNIEnv* env, jclass clazz, jobject jweb_contents) {
+static ScopedJavaLocalRef<jobject> FromWebContentsAndroid(
+ JNIEnv* env,
+ const JavaParamRef<jclass>& clazz,
+ const JavaParamRef<jobject>& jweb_contents) {
WebContents* web_contents = WebContents::FromJavaWebContents(jweb_contents);
if (!web_contents)
return ScopedJavaLocalRef<jobject>();
« no previous file with comments | « content/browser/android/content_video_view.cc ('k') | content/browser/android/content_view_render_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698