Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: content/app/android/child_process_service.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/app/android/child_process_service.cc
diff --git a/content/app/android/child_process_service.cc b/content/app/android/child_process_service.cc
index d3e6a1bf473883a57a4e69800e0b5721999096b5..68bf0c00d948ce7171f6a55183fb3b98a65c3ac7 100644
--- a/content/app/android/child_process_service.cc
+++ b/content/app/android/child_process_service.cc
@@ -149,7 +149,7 @@ void InternalInitChildProcess(JNIEnv* env,
} // namespace <anonymous>
void RegisterGlobalFileDescriptor(JNIEnv* env,
- jclass clazz,
+ const JavaParamRef<jclass>& clazz,
jint id,
jint fd,
jlong offset,
@@ -159,14 +159,14 @@ void RegisterGlobalFileDescriptor(JNIEnv* env,
}
void InitChildProcess(JNIEnv* env,
- jclass clazz,
- jobject service,
+ const JavaParamRef<jclass>& clazz,
+ const JavaParamRef<jobject>& service,
jint cpu_count,
jlong cpu_features) {
InternalInitChildProcess(env, clazz, service, cpu_count, cpu_features);
}
-void ExitChildProcess(JNIEnv* env, jclass clazz) {
+void ExitChildProcess(JNIEnv* env, const JavaParamRef<jclass>& clazz) {
VLOG(0) << "ChildProcessService: Exiting child process.";
base::android::LibraryLoaderExitHook();
_exit(0);
@@ -176,7 +176,7 @@ bool RegisterChildProcessService(JNIEnv* env) {
return RegisterNativesImpl(env);
}
-void ShutdownMainThread(JNIEnv* env, jobject obj) {
+void ShutdownMainThread(JNIEnv* env, const JavaParamRef<jobject>& obj) {
ChildThreadImpl::ShutdownThread();
}
« no previous file with comments | « components/variations/android/variations_associated_data_android.cc ('k') | content/app/android/content_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698