Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: chromecast/browser/android/cast_window_manager.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/base/chromecast_config_android.cc ('k') | components/cronet/android/chromium_url_request.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/browser/android/cast_window_manager.cc
diff --git a/chromecast/browser/android/cast_window_manager.cc b/chromecast/browser/android/cast_window_manager.cc
index c53005b46b3ad0ac92a1e91b0ca60439bbb8a149..c4e2f1274eaf582c7b61d2bf4e5771bb192f56eb 100644
--- a/chromecast/browser/android/cast_window_manager.cc
+++ b/chromecast/browser/android/cast_window_manager.cc
@@ -52,12 +52,16 @@ bool RegisterCastWindowManager(JNIEnv* env) {
return RegisterNativesImpl(env);
}
-void Init(JNIEnv* env, jclass clazz, jobject obj) {
+void Init(JNIEnv* env,
+ const JavaParamRef<jclass>& clazz,
+ const JavaParamRef<jobject>& obj) {
g_window_manager.Get().Reset(
base::android::ScopedJavaLocalRef<jobject>(env, obj));
}
-jlong LaunchCastWindow(JNIEnv* env, jclass clazz, jstring jurl) {
+jlong LaunchCastWindow(JNIEnv* env,
+ const JavaParamRef<jclass>& clazz,
+ const JavaParamRef<jstring>& jurl) {
GURL url(base::android::ConvertJavaStringToUTF8(env, jurl));
return reinterpret_cast<jlong>(
CastWindowAndroid::CreateNewWindow(
@@ -65,8 +69,10 @@ jlong LaunchCastWindow(JNIEnv* env, jclass clazz, jstring jurl) {
url));
}
-void StopCastWindow(JNIEnv* env, jclass clazz,
- jlong nativeCastWindow, jboolean gracefully) {
+void StopCastWindow(JNIEnv* env,
+ const JavaParamRef<jclass>& clazz,
+ jlong nativeCastWindow,
+ jboolean gracefully) {
CastWindowAndroid* window =
reinterpret_cast<CastWindowAndroid*>(nativeCastWindow);
DCHECK(window);
@@ -76,7 +82,9 @@ void StopCastWindow(JNIEnv* env, jclass clazz,
window->Destroy();
}
-void EnableDevTools(JNIEnv* env, jclass clazz, jboolean enable) {
+void EnableDevTools(JNIEnv* env,
+ const JavaParamRef<jclass>& clazz,
+ jboolean enable) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
CastBrowserProcess::GetInstance()->pref_service()->SetBoolean(
prefs::kEnableRemoteDebugging, enable);
« no previous file with comments | « chromecast/base/chromecast_config_android.cc ('k') | components/cronet/android/chromium_url_request.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698