Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: chrome/browser/ui/android/ssl_client_certificate_request.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/ssl_client_certificate_request.cc
diff --git a/chrome/browser/ui/android/ssl_client_certificate_request.cc b/chrome/browser/ui/android/ssl_client_certificate_request.cc
index 6ffdd57c5caab044ad84137d436c895a26940e8d..9956db1df0cf1a0fdfaeda4ba5c21f064fb196f3 100644
--- a/chrome/browser/ui/android/ssl_client_certificate_request.cc
+++ b/chrome/browser/ui/android/ssl_client_certificate_request.cc
@@ -121,10 +121,10 @@ namespace android {
// the user didn't select a certificate.
static void OnSystemRequestCompletion(
JNIEnv* env,
- jclass clazz,
+ const JavaParamRef<jclass>& clazz,
jlong request_id,
- jobjectArray encoded_chain_ref,
- jobject private_key_ref) {
+ const JavaParamRef<jobjectArray>& encoded_chain_ref,
+ const JavaParamRef<jobject>& private_key_ref) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
// Take back ownership of the delegate object.
@@ -179,7 +179,9 @@ static void NotifyClientCertificatesChanged() {
net::CertDatabase::GetInstance()->OnAndroidKeyStoreChanged();
}
-static void NotifyClientCertificatesChangedOnIOThread(JNIEnv* env, jclass) {
+static void NotifyClientCertificatesChangedOnIOThread(
+ JNIEnv* env,
+ const JavaParamRef<jclass>&) {
if (content::BrowserThread::CurrentlyOn(content::BrowserThread::IO)) {
NotifyClientCertificatesChanged();
} else {
« no previous file with comments | « chrome/browser/ui/android/omnibox/omnibox_view_util.cc ('k') | chrome/browser/ui/android/tab_model/single_tab_model.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698