chrome/browser/ui/android/javascript_app_modal_dialog_android.cc - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/javascript_app_modal_dialog_android.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/infobars/infobar_container_android.cc ('k') | chrome/browser/ui/android/omnibox/omnibox_url_emphasizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/javascript_app_modal_dialog_android.cc

diff --git a/chrome/browser/ui/android/javascript_app_modal_dialog_android.cc b/chrome/browser/ui/android/javascript_app_modal_dialog_android.cc

index 7b62d8bd2194d4e546cb11a62934faf2cad2975d..297a6d06b08801c04adc6ac0dc89fd242882f7bc 100644

--- a/chrome/browser/ui/android/javascript_app_modal_dialog_android.cc

+++ b/chrome/browser/ui/android/javascript_app_modal_dialog_android.cc

@@ -136,7 +136,9 @@ const ScopedJavaGlobalRef<jobject>&

}

// static

-ScopedJavaLocalRef<jobject> GetCurrentModalDialog(JNIEnv* env, jclass clazz) {

+ScopedJavaLocalRef<jobject> GetCurrentModalDialog(

+ JNIEnv* env,

+ const JavaParamRef<jclass>& clazz) {

app_modal::AppModalDialog* dialog =

app_modal::AppModalDialogQueue::GetInstance()->active_dialog();

if (!dialog || !dialog->native_dialog())