Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: chrome/browser/media/android/remote/record_cast_action.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/android/remote/record_cast_action.cc
diff --git a/chrome/browser/media/android/remote/record_cast_action.cc b/chrome/browser/media/android/remote/record_cast_action.cc
index 386083be0ffa72030a9a6e6914374ac160a3f470..7f9b5ad3a68fefc45ecde59d571ced73a8615445 100644
--- a/chrome/browser/media/android/remote/record_cast_action.cc
+++ b/chrome/browser/media/android/remote/record_cast_action.cc
@@ -43,18 +43,19 @@ enum RemotePlaybackDeviceType {
} // namespace
namespace remote_media {
-static void RecordRemotePlaybackDeviceSelected(
- JNIEnv*, jclass, jint device_type) {
+static void RecordRemotePlaybackDeviceSelected(JNIEnv*,
+ const JavaParamRef<jclass>&,
+ jint device_type) {
UMA_HISTOGRAM_ENUMERATION(
"Cast.Sender.DeviceType", device_type, REMOTE_PLAYBACK_DEVICE_TYPE_COUNT);
}
-static void RecordCastPlayRequested(JNIEnv*, jclass) {
+static void RecordCastPlayRequested(JNIEnv*, const JavaParamRef<jclass>&) {
RecordAction(UserMetricsAction("Cast_Sender_CastPlayRequested"));
}
static void RecordCastDefaultPlayerResult(JNIEnv*,
- jclass,
+ const JavaParamRef<jclass>&,
jboolean cast_success) {
if (cast_success) {
UMA_HISTOGRAM_ENUMERATION("Cast.Sender.CastPlayerResult",
@@ -68,7 +69,7 @@ static void RecordCastDefaultPlayerResult(JNIEnv*,
}
static void RecordCastYouTubePlayerResult(JNIEnv*,
- jclass,
+ const JavaParamRef<jclass>&,
jboolean cast_success) {
if (cast_success) {
UMA_HISTOGRAM_ENUMERATION("Cast.Sender.CastPlayerResult", YT_PLAYER_SUCCESS,
@@ -79,13 +80,15 @@ static void RecordCastYouTubePlayerResult(JNIEnv*,
}
}
-static void RecordCastMediaType(JNIEnv*, jclass, jint media_type) {
+static void RecordCastMediaType(JNIEnv*,
+ const JavaParamRef<jclass>&,
+ jint media_type) {
UMA_HISTOGRAM_ENUMERATION("Cast.Sender.CastMediaType", media_type,
media::container_names::CONTAINER_MAX);
}
static void RecordCastEndedTimeRemaining(JNIEnv*,
- jclass,
+ const JavaParamRef<jclass>&,
jint video_total_time,
jint time_left_in_video) {
int percent_remaining = 100;

Powered by Google App Engine
This is Rietveld 408576698