chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/web_contents_factory.cc ('k') | chrome/browser/autofill/android/personal_data_manager_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc

diff --git a/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc b/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc

index 03f310df77862c70d77693472cc0a6d7b0d92444..658cd3d1824f1a4448cdf4cd33a5b6d4b004e920 100644

--- a/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc

+++ b/chrome/browser/android/webapps/add_to_homescreen_dialog_helper.cc

@@ -24,7 +24,9 @@

using content::Manifest;

-jlong Initialize(JNIEnv* env, jobject obj, jobject java_web_contents) {

+jlong Initialize(JNIEnv* env,

+ const JavaParamRef<jobject>& obj,

+ const JavaParamRef<jobject>& java_web_contents) {

content::WebContents* web_contents =

content::WebContents::FromJavaWebContents(java_web_contents);

AddToHomescreenDialogHelper* add_to_homescreen_helper =

« no previous file with comments | « chrome/browser/android/web_contents_factory.cc ('k') | chrome/browser/autofill/android/personal_data_manager_android.cc » ('j') | no next file with comments »