chrome/browser/android/rappor/rappor_service_bridge.cc - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/rappor/rappor_service_bridge.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/provider/chrome_browser_provider.cc ('k') | chrome/browser/android/recently_closed_tabs_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/rappor/rappor_service_bridge.cc

diff --git a/chrome/browser/android/rappor/rappor_service_bridge.cc b/chrome/browser/android/rappor/rappor_service_bridge.cc

index 7dd7293bcaf71a122987256bfe09c1f633d5bf3e..f88b46aed802a544499c2be2b30fe2cf5fbfe08e 100644

--- a/chrome/browser/android/rappor/rappor_service_bridge.cc

+++ b/chrome/browser/android/rappor/rappor_service_bridge.cc

@@ -13,9 +13,9 @@

namespace rappor {

void SampleDomainAndRegistryFromURL(JNIEnv* env,

- jclass caller,

- jstring j_metric,

- jstring j_url) {

+ const JavaParamRef<jclass>& caller,

+ const JavaParamRef<jstring>& j_metric,

+ const JavaParamRef<jstring>& j_url) {

// TODO(knn): UMA metrics hash the string to prevent frequent re-encoding,

// perhaps we should do that as well.

std::string metric(base::android::ConvertJavaStringToUTF8(env, j_metric));