Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2064)

Unified Diff: chrome/browser/android/feedback/connectivity_checker.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/feedback/connectivity_checker.cc
diff --git a/chrome/browser/android/feedback/connectivity_checker.cc b/chrome/browser/android/feedback/connectivity_checker.cc
index 7c7fc6fcf2ed726d2deb178d30bf5e83939cf0ac..fa2e133090367a59beb7957a351d21daff670046 100644
--- a/chrome/browser/android/feedback/connectivity_checker.cc
+++ b/chrome/browser/android/feedback/connectivity_checker.cc
@@ -164,11 +164,11 @@ void ConnectivityChecker::OnTimeout() {
} // namespace
void CheckConnectivity(JNIEnv* env,
- jclass clazz,
- jobject j_profile,
- jstring j_url,
+ const JavaParamRef<jclass>& clazz,
+ const JavaParamRef<jobject>& j_profile,
+ const JavaParamRef<jstring>& j_url,
jlong j_timeout_ms,
- jobject j_callback) {
+ const JavaParamRef<jobject>& j_callback) {
Profile* profile = ProfileAndroid::FromProfileAndroid(j_profile);
if (!profile) {
PostCallback(env, j_callback, CONNECTIVITY_CHECK_RESULT_ERROR);
@@ -187,7 +187,9 @@ void CheckConnectivity(JNIEnv* env,
connectivity_checker->StartAsyncCheck();
}
-jboolean IsUrlValid(JNIEnv* env, jclass clazz, jstring j_url) {
+jboolean IsUrlValid(JNIEnv* env,
+ const JavaParamRef<jclass>& clazz,
+ const JavaParamRef<jstring>& j_url) {
GURL url(base::android::ConvertJavaStringToUTF8(env, j_url));
return url.is_valid();
}
« no previous file with comments | « chrome/browser/android/feature_utilities.cc ('k') | chrome/browser/android/find_in_page/find_in_page_bridge.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698