chrome/browser/android/compositor/scene_layer/reader_mode_scene_layer.cc - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/compositor/scene_layer/reader_mode_scene_layer.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/compositor/scene_layer/contextual_search_scene_layer.cc ('k') | chrome/browser/android/compositor/scene_layer/scene_layer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/compositor/scene_layer/reader_mode_scene_layer.cc

diff --git a/chrome/browser/android/compositor/scene_layer/reader_mode_scene_layer.cc b/chrome/browser/android/compositor/scene_layer/reader_mode_scene_layer.cc

index 80c22df2a92d5cb0d7c6a3b036ddbf5472647f1f..2817febd106715ea0a940fec009c88096976df8a 100644

--- a/chrome/browser/android/compositor/scene_layer/reader_mode_scene_layer.cc

+++ b/chrome/browser/android/compositor/scene_layer/reader_mode_scene_layer.cc

@@ -64,7 +64,7 @@ void ReaderModeSceneLayer::UpdateReaderModeLayer(

panel_text_opacity, header_background_color);

}

-static jlong Init(JNIEnv* env, jobject jobj) {

+static jlong Init(JNIEnv* env, const JavaParamRef<jobject>& jobj) {

// This will automatically bind to the Java object and pass ownership there.

ReaderModeSceneLayer* tree_provider =

new ReaderModeSceneLayer(env, jobj);