chrome/browser/android/compositor/compositor_view.cc - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/compositor/compositor_view.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/chrome_web_contents_delegate_android.cc ('k') | chrome/browser/android/compositor/layer_title_cache.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/compositor/compositor_view.cc

diff --git a/chrome/browser/android/compositor/compositor_view.cc b/chrome/browser/android/compositor/compositor_view.cc

index c89995eaaadb34b97dbbff05faa2dfb4a875177d..ff75b95fa2dfbd395b874293023e231d0dc0a936 100644

--- a/chrome/browser/android/compositor/compositor_view.cc

+++ b/chrome/browser/android/compositor/compositor_view.cc

@@ -41,12 +41,12 @@ namespace chrome {

namespace android {

jlong Init(JNIEnv* env,

- jobject obj,

+ const JavaParamRef<jobject>& obj,

jboolean low_mem_device,

jint empty_background_color,

jlong native_window_android,

- jobject jlayer_title_cache,

- jobject jtab_content_manager) {

+ const JavaParamRef<jobject>& jlayer_title_cache,

+ const JavaParamRef<jobject>& jtab_content_manager) {

CompositorView* view;

ui::WindowAndroid* window_android =

reinterpret_cast<ui::WindowAndroid*>(native_window_android);