base/android/jni_generator/testInnerClassNativesMultiple.golden - Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/android/jni_generator/testInnerClassNativesMultiple.golden

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/android/jni_generator/testInnerClassNativesBothInnerAndOuter.golden ('k') | base/android/jni_generator/testJNIInitNativeNameOption.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/android/jni_generator/testInnerClassNativesMultiple.golden

diff --git a/base/android/jni_generator/testInnerClassNativesMultiple.golden b/base/android/jni_generator/testInnerClassNativesMultiple.golden

index 5f543641aacb9fa29979ca55fd2b545e0e0614db..268f794e9561b31a75131b2718912a95168ab0d5 100644

--- a/base/android/jni_generator/testInnerClassNativesMultiple.golden

+++ b/base/android/jni_generator/testInnerClassNativesMultiple.golden

@@ -30,18 +30,18 @@ jclass g_TestJni_clazz = NULL;

// Step 2: method stubs.

-static jint Init(JNIEnv* env, jobject jcaller);

+static jint Init(JNIEnv* env, const JavaParamRef<jobject>& jcaller);

static jint Java_org_chromium_TestJni_00024MyInnerClass_nativeInit(JNIEnv* env,

jobject jcaller) {

- return Init(env, jcaller);

+ return Init(env, JavaParamRef<jobject>(env, jcaller));

}

-static jint Init(JNIEnv* env, jobject jcaller);

+static jint Init(JNIEnv* env, const JavaParamRef<jobject>& jcaller);

static jint Java_org_chromium_TestJni_00024MyOtherInnerClass_nativeInit(JNIEnv*

env, jobject jcaller) {

- return Init(env, jcaller);

+ return Init(env, JavaParamRef<jobject>(env, jcaller));

}

// Step 3: RegisterNatives.