Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1676)

Unified Diff: base/android/jni_generator/sample_for_tests.cc

Issue 1312153003: jni_generator: Pass object parameters as JavaParamRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/jni_generator/sample_for_tests.cc
diff --git a/base/android/jni_generator/sample_for_tests.cc b/base/android/jni_generator/sample_for_tests.cc
index a05909a46e66ab4976092a99a0018a070b16ab0c..a38377cc2f78a34fe4e6bfd66c565b6167789e98 100644
--- a/base/android/jni_generator/sample_for_tests.cc
+++ b/base/android/jni_generator/sample_for_tests.cc
@@ -66,22 +66,27 @@ base::android::ScopedJavaLocalRef<jstring> CPPClass::ReturnAString(
}
// Static free functions declared and called directly from java.
-static jlong Init(JNIEnv* env, jobject caller, jstring param) {
+static jlong Init(JNIEnv* env,
+ const JavaParamRef<jobject>& caller,
+ const JavaParamRef<jstring>& param) {
return 0;
}
-static jdouble GetDoubleFunction(JNIEnv*, jobject) {
+static jdouble GetDoubleFunction(JNIEnv*, const JavaParamRef<jobject>&) {
return 0;
}
-static jfloat GetFloatFunction(JNIEnv*, jclass) {
+static jfloat GetFloatFunction(JNIEnv*, const JavaParamRef<jclass>&) {
return 0;
}
-static void SetNonPODDatatype(JNIEnv*, jobject, jobject) {
-}
+static void SetNonPODDatatype(JNIEnv*,
+ const JavaParamRef<jobject>&,
+ const JavaParamRef<jobject>&) {}
-static ScopedJavaLocalRef<jobject> GetNonPODDatatype(JNIEnv*, jobject) {
+static ScopedJavaLocalRef<jobject> GetNonPODDatatype(
+ JNIEnv*,
+ const JavaParamRef<jobject>&) {
return ScopedJavaLocalRef<jobject>();
}
« no previous file with comments | « base/android/jni_generator/jni_generator_helper.h ('k') | base/android/jni_generator/testEagerCalledByNativesOption.golden » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698